New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable login prompts in Management Interface #57

Closed
linuxwolf opened this Issue Jan 14, 2019 · 2 comments

Comments

3 participants
@linuxwolf
Copy link
Member

linuxwolf commented Jan 14, 2019

Firefox may prompt the user to "save this login" while editing a login in the Lockbox management interface, which is confusing to the user and can present data storage issues (e.g., storing a loging not really intended for the hostname).

Instead, the prompts should be disabled while the management interface is the active tab.

Acceptance Critiera

  • User is not prompted to save a login they have added/editd in the management intertface

Notes

  • This may require manual testing
@lmorchard

This comment has been minimized.

Copy link
Contributor

lmorchard commented Feb 6, 2019

Some notes to myself, since I think I might have finally found the relevant pieces:

@linuxwolf

This comment has been minimized.

Copy link
Member Author

linuxwolf commented Feb 6, 2019

[adding to @lmorchard 's notes]

Based on experience:

  • the origin needs to be the chrome://<extension-uuid>; note the lack of a trailing /
  • it can be done at any point that the extension's baseURL is known, such as when the background script first starts

lmorchard added a commit to lmorchard/lockbox-addon that referenced this issue Feb 6, 2019

lmorchard added a commit to lmorchard/lockbox-addon that referenced this issue Feb 6, 2019

lmorchard added a commit to lmorchard/lockbox-addon that referenced this issue Feb 6, 2019

Disable prompts to save logins while on extension pages
- Add getLoginSavingEnabled and setLoginSavingEnabled methods to the
  Logins experiment API

- Disable login saving for extension pages on background startup

Fixes mozilla-lockbox#57

@wafflebot wafflebot bot added in progress and removed backlog labels Feb 6, 2019

lmorchard added a commit to lmorchard/lockbox-addon that referenced this issue Feb 8, 2019

Re-add login saving exception when it is somehow removed
- Add onLoginSavingChanged event to Logins API experiment to react to
  changes in login saving exceptions

- Watch for the removal of the login saving exception for this add-on's
  management pages. Re-add when removed.

Fixes mozilla-lockbox#57

@lmorchard lmorchard changed the title Disable login prompts in Management Interface WIP: Disable login prompts in Management Interface Feb 8, 2019

@lmorchard lmorchard changed the title WIP: Disable login prompts in Management Interface Disable login prompts in Management Interface Feb 8, 2019

lmorchard added a commit to lmorchard/lockbox-addon that referenced this issue Feb 8, 2019

Disable prompts to save logins while on extension pages
- Add getLoginSavingEnabled and setLoginSavingEnabled methods to the
  Logins experiment API

- Disable login saving for extension pages on background startup

Fixes mozilla-lockbox#57

lmorchard added a commit to lmorchard/lockbox-addon that referenced this issue Feb 8, 2019

Re-add login saving exception when it is somehow removed
- Add onLoginSavingChanged event to Logins API experiment to react to
  changes in login saving exceptions

- Watch for the removal of the login saving exception for this add-on's
  management pages. Re-add when removed.

Fixes mozilla-lockbox#57

lmorchard added a commit to lmorchard/lockbox-addon that referenced this issue Feb 11, 2019

Disable prompts to save logins while on extension pages
- Add getLoginSavingEnabled and setLoginSavingEnabled methods to the
  Logins experiment API

- Disable login saving for extension pages on background startup

Fixes mozilla-lockbox#57

lmorchard added a commit that referenced this issue Feb 11, 2019

Disable prompts to save logins while on extension pages (#74)
- Add getLoginSavingEnabled and setLoginSavingEnabled methods to the
  Logins experiment API

- Disable login saving for extension pages on background startup

Fixes #57

@wafflebot wafflebot bot removed the in progress label Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment