This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Add telemetry events for relevant actions in the extension #29
Comments
sandysage
changed the title
Add telemetry events for relevant actions in app
Add telemetry events for relevant actions in the extension
Dec 14, 2018
I think this probably starts as modifying the existing metrics.md. |
Implementation will be straightforward: the telemetry API exposes everything we need. Most of the work in this bug will be the legal & data reviews. |
Closed
Merged
ghost
assigned irrationalagent
Feb 19, 2019
ghost
added
the
in progress
label
Feb 19, 2019
🤣 |
jaredhirsch
added a commit
to jaredhirsch/lockbox-addon
that referenced
this issue
Apr 9, 2019
Fixes mozilla-lockwise#29. * Opted to keep the telemetry calls in the redux middleware, and added some actions that don't affect the redux store, but are only used by the telemetry middleware. Seemed cleaner than giving various components and containers knowledge of the telemetry library. * Refactored the telemetry methods to use an options object instead of positional args. In our new metrics, value is optional and sometimes null, and extra is optional and sometimes null; and it seemed that getting the positional order right could be bug-prone. * Added embedded telemetry API experiment to work around recordEvent bug in Firefox. * Added an onReveal method to trigger an action, so we can count the password reveal clicks via telemetry. * Removed the `reconnecting_sync` event, because we don't yet show any UI in the FxA menu in the error case. * Set `record_on_release` to `true` for everything, because our users are opting in by installing the addon (or clicking a button to enable it). * Added telemetry event info to pull request template.
jaredhirsch
added a commit
that referenced
this issue
Apr 9, 2019
Fixes #29. * Opted to keep the telemetry calls in the redux middleware, and added some actions that don't affect the redux store, but are only used by the telemetry middleware. Seemed cleaner than giving various components and containers knowledge of the telemetry library. * Refactored the telemetry methods to use an options object instead of positional args. In our new metrics, value is optional and sometimes null, and extra is optional and sometimes null; and it seemed that getting the positional order right could be bug-prone. * Added embedded telemetry API experiment to work around recordEvent bug in Firefox. * Added an onReveal method to trigger an action, so we can count the password reveal clicks via telemetry. * Removed the `reconnecting_sync` event, because we don't yet show any UI in the FxA menu in the error case. * Set `record_on_release` to `true` for everything, because our users are opting in by installing the addon (or clicking a button to enable it). * Added telemetry event info to pull request template.
ghost
removed
the
in progress
label
Apr 9, 2019
This was referenced Apr 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As the product owner, I want to know how users engage with the app to help inform decisions for future effort, while making sure users have control over whether or not their usage data is submitted.
Acceptance criteria
The text was updated successfully, but these errors were encountered: