Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
32 manage page list styles #76
Testing and Review Notes
Visual updates based on the zeplin mocks linked in #32.
This PR should only impact the management page list view; watch out for unexpected changes to the panel list view.
Questions for dev:
Question for UX:
I wasn't clear on the differences between hover, focus, and active states, based on the zeplin mocks. I'm particularly curious if these three states look correct for the list item, the search field, and the '+' button.
Screenshots or Videos
I'm going to skip these, to encourage reviewers to actually exercise the code a bit (afraid I'm missing some edge cases)...but if this seems a little too lazy on my part, I can add side-by-side screenshots for comparison purposes
nickbrandt left a comment •
Overall, this is fantastic! Everything is just about spot on, with just a couple small nits (and a mistake on my end).
Main List View
Search (I think this is included in your PR)
Nice work @6a68 !