33 details dropdown #87
Merged
Conversation
When webdriver opens the extension page, the browser.experiments.logins
API is not present. When I open the extension page myself, via going to
about:debugging, and doing
browser.tabs.create({
url: browser.extension.getURL(
"/test/integration/test-pages/logins-api.html")
}),
the test page seems just fine. Maybe webdriver needs some magic powers?
* The webextensions framework auto-inserts 'null' default values for any specified keys that are missing, causing updates to break LoginManager.modifyLogin() type checking. Filter out those null values. * Create a coding convention to make clearer which things are vanilla JS objects with login fields, which are nsILoginInfo objects, and which are nsIPropertyBags used to modifyLogin.
Logins API
Connected to #21
…API to apply changes
Initial minimal logins API connection to datastore
meandavejustice
requested a review
from mozilla-lockwise/desktop-engineering
as a
code owner
ghost
assigned
|
No idea why commit history is looking so insane, it's been rebased with master and the diffs are correct |
|
Overall it's looking great! I have some inline suggestions, and some global things to address:
The "go back" hit target on And that hit target on |
|
Took a swing through and found a couple nits. We've also got some bits that are going to conflict between here and PR #90. But, the changes here are more involved (e.g. two buttons in a toolbar versus my one added delete button) - so I'd be inclined to let this land first and then revise / rebase my PR |
|
@linuxwolf Addressed hit target on back button |
|
really looking and feeling awesome! Some things I really should have caught sooner; very sorry for not! |
- fixes #33
|
r+ Perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #33