Edit Entry Details in Management Interface #90
Conversation
ghost
assigned
|
Look and behaves awesomely! This just about matches the designs Inline there are a requested change or two. The biggest thing I've seem missing is a callout "bubble" when the "website address" field is focused, with instructions on what's expected: Also, I've encountered an interesting bug: a very long password (not entirely sure on the size, sorry!) |
| // Focus the first editable field... | ||
| if (this.props.fields.itemId) { | ||
| // For existing items, the first field is disabled. | ||
| this._secondField.focus(); |
linuxwolf
Feb 26, 2019
Contributor
I think there's been some change in product requirements here (i.e., "Website address" is always editable). cc @sandysage for confirmation.
If so, I would propose a follow-up issue; there be dragons if this field is editable.
I think there's been some change in product requirements here (i.e., "Website address" is always editable). cc @sandysage for confirmation.
If so, I would propose a follow-up issue; there be dragons if this field is editable.
linuxwolf
Feb 27, 2019
Contributor
discussed with @sandysage , and there is a change that had not been reflected into the desktop designs yet (it is in the mobile CRUD designs).
I'm going to file a follow up for this; editable hostname has complications/concerns we need to make sure we understand.
discussed with @sandysage , and there is a change that had not been reflected into the desktop designs yet (it is in the mobile CRUD designs).
I'm going to file a follow up for this; editable hostname has complications/concerns we need to make sure we understand.
| <h1>nEw iTEm</h1> | ||
| </Localized> | ||
| ) : ( | ||
| <React.Fragment> |
linuxwolf
Feb 26, 2019
Contributor
TIL about React.Fragment 🌈 🌟
TIL about React.Fragment
lmorchard
Feb 26, 2019
Author
Contributor
Yeah, I think you can also use <> and </> but I like explicitly naming the React.Fragment component.
Yeah, I think you can also use <> and </> but I like explicitly naming the React.Fragment component.
| position: relative; | ||
| } | ||
|
|
||
| .item-details > h1, |
lmorchard
Feb 26, 2019
Author
Contributor
Hmm, it probably will, but we should probably also just rebase / revise against whichever lands first? Not sure how to pre-emptively handle that well
Hmm, it probably will, but we should probably also just rebase / revise against whichever lands first? Not sure how to pre-emptively handle that well
I think that's part of issue #30 as the "helper" in the specs. At least, that's where I started implementing it on a branch a few weeks ago
Hmm, probably have some text disappearing under the hide / show button, will take a look |
Ah, right. Ignore this and carry on! |
lmorchard
force-pushed the
lmorchard:34-edit-details
branch
2 times, most recently
from
bc9b64a
to
0abb5f1
|
Okay, made some tweaks to fix the hidden bit of the password field and updated the field placeholder. Not entirely sure how / if to be proactive about a conflict with #87 |
|
Just checked it over, and it's working great! At worst, the cursor disappears at the extreme edge, but arrowing left brings it back to visible. |
- Tweaks to editing fields to better match UX spec - Item title now appears in header for editing - Disabled origin field on editing - Add delete button in header of edit view - New delete.svg icon Fixes #34
|
Rebased, resolved conflicts. Mainly little CSS tweaks, so I might merge after a successful test run. |
Fixes #34