Sync profile info and menu #37 & #72

[lmorchard]

Working toward implementing the profile menu and info display. Running into some issues and looking for an image asset, but figured I'd get a PR started for general kibbitzing.

Only meant to tackle one of these, but the two seemed to naturally run into each other.

Fixes #37
Fixes #72

Testing and Review Notes

• Profile info in upper right should be reactive to signing in and out of sync.
• Clicking on the icon in upper right should make a menu appear, which is adaptive to sync sign-in status.

To Do

• Add unit tests and get coverage back up
• Wrap en-US strings for l10n
• Handle in Issue #92 Figure out how to link to "Sign in to Sync" - just opening an about:sync URL is not allowed. Maybe needs a Sync API experiment addition?
• Need to find a "pointer" image to add to the menu bubble so it's connected to the avatar visually
• Handle in other issues (e.g.) Need to verify other menu items are linking to the right things
• Ensure the avatar display is correct - my account has no avatar, so it's just the anonymous image.
• Remove the dev hack commit that opens the management page on reload!

[linuxwolf]

Figure out how to link to "Sign in to Sync" - just opening an about:sync URL is not allowed. Maybe needs a Sync API experiment addition?

#61 has some details on this, but the "TL;DR" is we'll need an extra method on the sync API to make the right calls and open the page. For some reason, I thought we already had, but now seem to recall from IRL discussions it would be pushed until this issue was to get done (-:

[jaredhirsch]

@lmorchard The sync folks pointed me at gSync.openPrefs as the right way to open the about:preferences#sync page, which we would indeed need to call from a new Sync API function: https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/browser/base/content/browser-sync.js#656

See also the usage of openPrefs elsewhere in that file: https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/browser/base/content/browser-sync.js#273

I think we want to change the entryPoint value to something lockbox-specific. I've been told this will be passed to fxa server-side telemetry, but not firefox telemetry, so it'll help tell us something indirectly about lockbox usage, but I'm not sure where we'd put that in the metrics.md doc. As for addon telemetry, the metrics doc does mention reconnect_sync and signin_sync for clicks on this menu item.

[jaredhirsch]

whoops! I gotta remember to refresh before leaving comments :-P

[linuxwolf]

We ought to discuss/verify with @mozilla-lockbox/product ...

I believe (but seem to not have recorded herein) that handing some specific calls -- like opening the sync prefs a la #61 -- is deferred to those issues. The rationale being to divide the work into accomplishable chunks.

Personally, I would consider making making the individual menu items truly work to be a stretch goal for this PR, and should be captured in other issues already.

[lmorchard]

Personally, I would consider making making the individual menu items truly work to be a stretch goal for this PR, and should be captured in other issues already.

Just noticed issue #92 - I'd be fine with deferring the menu items here to other issues. I'm kind of guessing on some of the URLs, and I assume there should / will be telemetry asks for them that I haven't implemented here.

[linuxwolf]

Just noticed issue #92 - I'd be fine with deferring the menu items here to other issues. I'm kind of guessing on some of the URLs, and I assume there should / will be telemetry asks for them that I haven't implemented here.

In your defense, some of the expectations/details weren't as spelled out as maybe they should have been before you started the work.

I'm walking through this PR to leave comments, hopefully it helps avoid some extra churn.

[linuxwolf]

🚜 drive-by 🚜

although still a WIP this is impressive; as far as I can tell it's just missing tests -- all the expected visuals and functionality are in place!

My only general comment regards the links to external assets (FAQ, Feedback): they are opening in a new window. @meandavejustice encountered this with doorhanger work, and resulted in the "open_site" background message, which I think also happily aids in future telemetry work?

More comments inline, and great work.

[lmorchard]

Whew, okay - this should have unit tests now, except for some of the TODO bits. Also squashed commits and tidied up a bit, so I think this qualifies as no longer WIP (pending any further review notes)

[linuxwolf]

r+

very awesome!