Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Setup continous integration and deployment #12

Closed
9 of 11 tasks
pocmo opened this issue Mar 21, 2018 · 2 comments · Fixed by #12649
Closed
9 of 11 tasks

Setup continous integration and deployment #12

pocmo opened this issue Mar 21, 2018 · 2 comments · Fixed by #12649
Assignees
@pocmo
Labels
automation Build automation, Continuous integration, ..

Comments

@pocmo
Copy link
Contributor

pocmo commented Mar 21, 2018 •
edited by data-sync-user

Continuous integration

  • Create basic build configuration
  • Run tests in automation
  • Create custom docker image with all dependencies
  • Run code quality tools (at least lint, detekt and ktlint)
    • detekt
    • lint
    • ktlint
  • Save reports in artifacts

Release configuration

  • Create centralized configuration for releases (version number, ..)

Deployment

┆Issue is synchronized with this Jira Task
@pocmo pocmo added the automation Build automation, Continuous integration, .. label Mar 21, 2018
@pocmo pocmo self-assigned this Mar 21, 2018
pocmo referenced this issue in pocmo/android-components Mar 21, 2018
@pocmo
Issue #12 - Use kotlin version constant in all build files.
0023c06
pocmo referenced this issue in pocmo/android-components Mar 21, 2018
@pocmo
Issue #12: support-utils: Compile Kotlin stdlib into test artifact.
17aebf9
pocmo referenced this issue in pocmo/android-components Mar 21, 2018
@pocmo
Issue #12: Run unit tests on taskcluster.
8e8b352
pocmo referenced this issue in pocmo/android-components Mar 21, 2018
@pocmo
Issue #12: Use kotlin version constant in all build files.
69cb6d8
pocmo referenced this issue in pocmo/android-components Mar 21, 2018
@pocmo
Issue #12: support-utils: Compile Kotlin stdlib into test artifact.
0c7c603
pocmo referenced this issue in pocmo/android-components Mar 21, 2018
@pocmo
Issue #12: Run unit tests on taskcluster.
f8ed2ef
pocmo referenced this issue in pocmo/android-components Mar 21, 2018
@pocmo
Issue #12 - Add detekt and run it in automation.
e1dc4df
pocmo referenced this issue in pocmo/android-components Mar 21, 2018
@pocmo
Issue #12: Add detekt and run it in automation.
ec0c4af
pocmo added a commit that referenced this issue Mar 21, 2018
@pocmo
Issue #12: Use kotlin version constant in all build files.
78159b6
pocmo added a commit that referenced this issue Mar 21, 2018
@pocmo
Issue #12: support-utils: Compile Kotlin stdlib into test artifact.
d50bb61
pocmo added a commit that referenced this issue Mar 21, 2018
@pocmo
Issue #12: Run unit tests on taskcluster.
325da43
pocmo added a commit that referenced this issue Mar 21, 2018
@pocmo
Issue #12: Add detekt and run it in automation.
86850fe
pocmo referenced this issue in pocmo/android-components Mar 21, 2018
@pocmo
Issue #12: Add ktlint and run in automation.
f0971f9
pocmo referenced this issue in pocmo/android-components Mar 21, 2018
@pocmo
Issue #12: Fix issues uncovered by ktlint.
40ca200
pocmo referenced this issue in pocmo/android-components Mar 21, 2018
@pocmo
Issue #12: Remove/update outdated gradle configurations.
73e8ba6
pocmo added a commit that referenced this issue Mar 22, 2018
@pocmo
Issue #12: Add ktlint and run in automation.
3500189
pocmo added a commit that referenced this issue Mar 22, 2018
@pocmo
Issue #12: Fix issues uncovered by ktlint.
bf8e974
pocmo added a commit that referenced this issue Mar 22, 2018
@pocmo
Issue #12: Remove/update outdated gradle configurations.
eec7090
pocmo referenced this issue in pocmo/android-components Mar 22, 2018
@pocmo
Issue #12: Abort build on lint errors and warnings.
e6c02e5
pocmo referenced this issue in pocmo/android-components Mar 22, 2018
@pocmo
Issue #12: Run lint on taskcluster.
9b7b078
pocmo added a commit that referenced this issue Mar 22, 2018
@pocmo
Issue #12: Create custom Docker image for building on taskcluster.
5a46e1b
pocmo added a commit that referenced this issue Mar 22, 2018
@pocmo
Issue #12: Use custom Docker image to build on taskcluster.
64e0436
pocmo added a commit that referenced this issue Mar 22, 2018
@pocmo
Issue #12: Do not use local.properties workaround anymore.
60a5ecf
pocmo referenced this issue in pocmo/android-components Mar 22, 2018
@pocmo
Issue #12: Centralize configuration of minSdkVersion and targetSdkVer…
741fbfc 
…sion.
pocmo referenced this issue in pocmo/android-components Mar 22, 2018
@pocmo
Issue #12: Fix issues uncovered by lint and suppress false positives.
f312b5e
pocmo referenced this issue in pocmo/android-components Mar 22, 2018
@pocmo
Issue #12: Fix issues uncovered by lint and suppress false positives.
f5ebc3c
pocmo added a commit that referenced this issue Mar 22, 2018
@pocmo
Issue #12: Abort build on lint errors and warnings.
944c4fb
pocmo added a commit that referenced this issue Mar 22, 2018
@pocmo
Issue #12: Run lint on taskcluster.
0d807bf
pocmo added a commit that referenced this issue Mar 22, 2018
@pocmo
Issue #12: Centralize configuration of minSdkVersion and targetSdkVer…
78f2669 
…sion.
pocmo added a commit that referenced this issue Mar 22, 2018
@pocmo
Issue #12: Fix issues uncovered by lint and suppress false positives.
7f3fec3
pocmo added a commit that referenced this issue Mar 23, 2018
@pocmo
Issue #12: Use custom Docker image to build on taskcluster.
badbac6
pocmo added a commit that referenced this issue Mar 23, 2018
@pocmo
Issue #12: Do not use local.properties workaround anymore.
815d09c
pocmo referenced this issue in pocmo/android-components Mar 23, 2018
@pocmo
Issue #12: Keep build reports as artifacts on taskcluster.
aebf92c
pocmo referenced this issue in pocmo/android-components Mar 23, 2018
@pocmo
Issue #12: Create centralized configuration for uploading libraries t…
756becd 
…o jcenter.
pocmo added a commit that referenced this issue Mar 23, 2018
@pocmo
Issue #12: Create custom Docker image for building on taskcluster.
607120c
pocmo added a commit that referenced this issue Mar 23, 2018
@pocmo
Issue #12: Use custom Docker image to build on taskcluster.
39c7401
pocmo added a commit that referenced this issue Mar 23, 2018
@pocmo
Issue #12: Do not use local.properties workaround anymore.
4668e08
pocmo added a commit that referenced this issue Mar 23, 2018
@pocmo
Issue #12: Keep build reports as artifacts on taskcluster.
24e9bd4
pocmo added a commit that referenced this issue Mar 23, 2018
@pocmo
Issue #12: Create centralized configuration for uploading libraries t…
e27d87e 
…o jcenter.
@pocmo
Copy link
Contributor Author

pocmo commented Mar 26, 2018

Requested a taskcluster project namespace for this here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1448984

This was referenced Mar 27, 2018
Closed
Closed
@pocmo
Copy link
Contributor Author

pocmo commented Mar 27, 2018

Created two follow-up issues for publishing.

@pocmo pocmo closed this as completed Mar 27, 2018
pocmo referenced this issue in pocmo/android-components Mar 28, 2018
@pocmo
Issue #12: Add new task for building and publishing releases.
0b76a07
pocmo referenced this issue in pocmo/android-components Apr 25, 2018
@pocmo
Add missing core ping fields.
a69e1f2 
* Search counts - Fixes mozilla-mobile#14
* Default search - Fixes #12
* Profile creation date - Fixes #11
* Device architecture - Fixes #10
pocmo referenced this issue in pocmo/android-components Jul 17, 2018
@fercarcedo
Issue #12: Implement simple API for getting experiment metadata
36b17e1 
Closes #12: Implement simple API for getting experiment metadata

Fretboard withExperiment refactored to more idiomatic Kotlin

Mention that Fretboard getExperiment method will return the Experiment even if the user is not part of it

Warn that for now we decided to support primitive types only as payload
Bubu added a commit to Bubu/android-components that referenced this issue Aug 13, 2022
@Bubu
Make sharing images work with Direct Share
293ae71 
Image sharing currently only works when sharing to an app but not when
using the Android Direct Share feature, where it fails with a
SecurityException.

"Direct Share" is what Android calls the app created shortcuts,
i.e. individual chats from a messaging application.

The code pretty much already does the right thing (i.e. setting
the FLAG_GRANT_READ_URI_PERMISSION on the target intent as well as the
Chooser action, as described in ACTION_CHOOSE Api docs[1]) but there's
some platform internals that seem to go wrong here but we can work
around it with this patch.

https://issuetracker.google.com/issues/151386328 describes a similar
Problem, especially mozilla-mobile#12 in there offers a similar workaround and an
explanation:

  The underlying problem is that ACTION_SEND is using EXTRA_STREAM for the
  content URI. But the FLAG_GRANT_*_URI_PERMISSION mechanism only works
  with URIs in Intent.data and Intent.clipData. The framework contains
  some code that tries to work around this limitation. But it doesn't
  handle this particular case. Intent.createChooser() migrates the flags
  and data/clipData from the target Intent, but it does so before the
  framework had a chance to fix up the target Intent via Intent.migrateExtraStreamToClipData().

And indeed moving the clipData into the inner intent makes Direct Share
work and preserves the image preview in the Intent.

[1] file:///<SDK-DIR>/docs/reference/android/content/Intent.html#ACTION_CHOOSER
  If you need to grant URI permissions through a chooser, you must specify
  the permissions to be granted on the ACTION_CHOOSER Intent in addition to
  the EXTRA_INTENT inside. This means using setClipData(ClipData) to
  specify the URIs to be granted as well as FLAG_GRANT_READ_URI_PERMISSION
  and/or FLAG_GRANT_WRITE_URI_PERMISSION as appropriate.
@Bubu Bubu mentioned this issue Aug 13, 2022
Merged
4 tasks
Bubu added a commit to Bubu/android-components that referenced this issue Aug 25, 2022
@Bubu
Close mozilla-mobile#12689: Make sharing images work with Direct Share
f7d3d81 
Image sharing currently only works when sharing to an app but not when
using the Android Direct Share feature, where it fails with a
SecurityException.

"Direct Share" is what Android calls the app created shortcuts,
i.e. individual chats from a messaging application.

The code pretty much already does the right thing (i.e. setting
the FLAG_GRANT_READ_URI_PERMISSION on the target intent as well as the
Chooser action, as described in ACTION_CHOOSE Api docs[1]) but there's
some platform internals that seem to go wrong here but we can work
around it with this patch.

https://issuetracker.google.com/issues/151386328 describes a similar
Problem, especially mozilla-mobile#12 in there offers a similar workaround and an
explanation:

  The underlying problem is that ACTION_SEND is using EXTRA_STREAM for the
  content URI. But the FLAG_GRANT_*_URI_PERMISSION mechanism only works
  with URIs in Intent.data and Intent.clipData. The framework contains
  some code that tries to work around this limitation. But it doesn't
  handle this particular case. Intent.createChooser() migrates the flags
  and data/clipData from the target Intent, but it does so before the
  framework had a chance to fix up the target Intent via Intent.migrateExtraStreamToClipData().

And indeed moving the clipData into the inner intent makes Direct Share
work and preserves the image preview in the Intent.

[1] file:///<SDK-DIR>/docs/reference/android/content/Intent.html#ACTION_CHOOSER
  If you need to grant URI permissions through a chooser, you must specify
  the permissions to be granted on the ACTION_CHOOSER Intent in addition to
  the EXTRA_INTENT inside. This means using setClipData(ClipData) to
  specify the URIs to be granted as well as FLAG_GRANT_READ_URI_PERMISSION
  and/or FLAG_GRANT_WRITE_URI_PERMISSION as appropriate.
@github-actions github-actions bot mentioned this issue Aug 26, 2022
Closed
4 tasks
mergify bot pushed a commit that referenced this issue Aug 26, 2022
@Bubu @mergify
Close #12689: Make sharing images work with Direct Share
3569097 
Image sharing currently only works when sharing to an app but not when
using the Android Direct Share feature, where it fails with a
SecurityException.

"Direct Share" is what Android calls the app created shortcuts,
i.e. individual chats from a messaging application.

The code pretty much already does the right thing (i.e. setting
the FLAG_GRANT_READ_URI_PERMISSION on the target intent as well as the
Chooser action, as described in ACTION_CHOOSE Api docs[1]) but there's
some platform internals that seem to go wrong here but we can work
around it with this patch.

https://issuetracker.google.com/issues/151386328 describes a similar
Problem, especially #12 in there offers a similar workaround and an
explanation:

  The underlying problem is that ACTION_SEND is using EXTRA_STREAM for the
  content URI. But the FLAG_GRANT_*_URI_PERMISSION mechanism only works
  with URIs in Intent.data and Intent.clipData. The framework contains
  some code that tries to work around this limitation. But it doesn't
  handle this particular case. Intent.createChooser() migrates the flags
  and data/clipData from the target Intent, but it does so before the
  framework had a chance to fix up the target Intent via Intent.migrateExtraStreamToClipData().

And indeed moving the clipData into the inner intent makes Direct Share
work and preserves the image preview in the Intent.

[1] file:///<SDK-DIR>/docs/reference/android/content/Intent.html#ACTION_CHOOSER
  If you need to grant URI permissions through a chooser, you must specify
  the permissions to be granted on the ACTION_CHOOSER Intent in addition to
  the EXTRA_INTENT inside. This means using setClipData(ClipData) to
  specify the URIs to be granted as well as FLAG_GRANT_READ_URI_PERMISSION
  and/or FLAG_GRANT_WRITE_URI_PERMISSION as appropriate.
jonalmeida pushed a commit to jonalmeida/android-components that referenced this issue Aug 31, 2022
@Bubu @jonalmeida
Close mozilla-mobile#12689: Make sharing images work with Direct Share
aeea838 
Image sharing currently only works when sharing to an app but not when
using the Android Direct Share feature, where it fails with a
SecurityException.

"Direct Share" is what Android calls the app created shortcuts,
i.e. individual chats from a messaging application.

The code pretty much already does the right thing (i.e. setting
the FLAG_GRANT_READ_URI_PERMISSION on the target intent as well as the
Chooser action, as described in ACTION_CHOOSE Api docs[1]) but there's
some platform internals that seem to go wrong here but we can work
around it with this patch.

https://issuetracker.google.com/issues/151386328 describes a similar
Problem, especially mozilla-mobile#12 in there offers a similar workaround and an
explanation:

  The underlying problem is that ACTION_SEND is using EXTRA_STREAM for the
  content URI. But the FLAG_GRANT_*_URI_PERMISSION mechanism only works
  with URIs in Intent.data and Intent.clipData. The framework contains
  some code that tries to work around this limitation. But it doesn't
  handle this particular case. Intent.createChooser() migrates the flags
  and data/clipData from the target Intent, but it does so before the
  framework had a chance to fix up the target Intent via Intent.migrateExtraStreamToClipData().

And indeed moving the clipData into the inner intent makes Direct Share
work and preserves the image preview in the Intent.

[1] file:///<SDK-DIR>/docs/reference/android/content/Intent.html#ACTION_CHOOSER
  If you need to grant URI permissions through a chooser, you must specify
  the permissions to be granted on the ACTION_CHOOSER Intent in addition to
  the EXTRA_INTENT inside. This means using setClipData(ClipData) to
  specify the URIs to be granted as well as FLAG_GRANT_READ_URI_PERMISSION
  and/or FLAG_GRANT_WRITE_URI_PERMISSION as appropriate.
@github-actions github-actions bot mentioned this issue Aug 31, 2022
Merged
4 tasks
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Sep 7, 2022
@Bubu @mergify
[components] Close mozilla-mobile/android-components#12689: Make shar…
822892f 
…ing images work with Direct Share

Image sharing currently only works when sharing to an app but not when
using the Android Direct Share feature, where it fails with a
SecurityException.

"Direct Share" is what Android calls the app created shortcuts,
i.e. individual chats from a messaging application.

The code pretty much already does the right thing (i.e. setting
the FLAG_GRANT_READ_URI_PERMISSION on the target intent as well as the
Chooser action, as described in ACTION_CHOOSE Api docs[1]) but there's
some platform internals that seem to go wrong here but we can work
around it with this patch.

https://issuetracker.google.com/issues/151386328 describes a similar
Problem, especially (mozilla-mobile/android-components#12) in there offers a similar workaround and an
explanation:

  The underlying problem is that ACTION_SEND is using EXTRA_STREAM for the
  content URI. But the FLAG_GRANT_*_URI_PERMISSION mechanism only works
  with URIs in Intent.data and Intent.clipData. The framework contains
  some code that tries to work around this limitation. But it doesn't
  handle this particular case. Intent.createChooser() migrates the flags
  and data/clipData from the target Intent, but it does so before the
  framework had a chance to fix up the target Intent via Intent.migrateExtraStreamToClipData().

And indeed moving the clipData into the inner intent makes Direct Share
work and preserves the image preview in the Intent.

[1] file:///<SDK-DIR>/docs/reference/android/content/Intent.html#ACTION_CHOOSER
  If you need to grant URI permissions through a chooser, you must specify
  the permissions to be granted on the ACTION_CHOOSER Intent in addition to
  the EXTRA_INTENT inside. This means using setClipData(ClipData) to
  specify the URIs to be granted as well as FLAG_GRANT_READ_URI_PERMISSION
  and/or FLAG_GRANT_WRITE_URI_PERMISSION as appropriate.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

Labels
automation Build automation, Continuous integration, ..
Projects
None yet
Milestone
No milestone
1 participant
@pocmo