Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(lib-crash) After simulating a non fatal crash ("about:crashcontent") on GV and clicking return to the app gets a black screen #1333

Closed
Amejia481 opened this issue Nov 13, 2018 · 6 comments

Comments

@Amejia481
Copy link
Contributor

commented Nov 13, 2018

This video shows the steps to replicate the issue

@Amejia481 Amejia481 added the <crash> label Nov 13, 2018

@pocmo pocmo added the 🐞 bug label Nov 13, 2018

@pocmo pocmo added this to the 0.32 milestone Nov 13, 2018

@Amejia481 Amejia481 self-assigned this Nov 13, 2018

@pocmo pocmo added the S label Nov 16, 2018

@pocmo

This comment has been minimized.

Copy link
Contributor

commented Nov 16, 2018

@Amejia481 I'm going to add this to a user story and set it size to "S" here. If you disagree then please set it to something larger. :)

@Amejia481

This comment has been minimized.

Copy link
Contributor Author

commented Nov 16, 2018

👍

@st3fan st3fan added this to Sprint Backlog in Android Components Sprint Planning Nov 19, 2018

@Amejia481

This comment has been minimized.

Copy link
Contributor Author

commented Nov 19, 2018

I was doing some testing and it looks like the main issue realise on about:crashcontent.

Could simulate sending reports without any problem:

val intent = Intent("org.mozilla.gecko.ACTION_CRASHED")
           intent.component = ComponentName(
               packageName,
               "mozilla.components.lib.crash.handler.CrashHandlerService"
           )
           intent.putExtra(
               "minidumpPath",
               "${filesDir.path}/mozilla/Crash Reports/pending/6f37f606-a5d8-4c47-fa4e-5c4598fcf802.dmp"
           )
           intent.putExtra("fatal", false)
           intent.putExtra(
               "extrasPath",
               "${filesDir.path}/mozilla/Crash Reports/pending/6f37f606-a5d8-4c47-fa4e-5c4598fcf802.extra"
           )
           intent.putExtra("minidumpSuccess", true)

           ContextCompat.startForegroundService(context, intent)

The problem comes after simulating it using about:crashcontent, as the docs suggested, after that the app gets completely unresponsive. I couldn't find about:crashcontent in our codet is this handle on GV side?

@pocmo

This comment has been minimized.

Copy link
Contributor

commented Nov 19, 2018

@Amejia481

This comment has been minimized.

Copy link
Contributor Author

commented Nov 19, 2018

Thanks, let me take a look at it!

@pocmo pocmo moved this from Sprint Backlog to In Progress in Android Components Sprint Planning Nov 19, 2018

@pocmo pocmo removed this from the 0.32 🎿 milestone Nov 19, 2018

Amejia481 added a commit to Amejia481/android-components that referenced this issue Nov 19, 2018

Amejia481 added a commit to Amejia481/android-components that referenced this issue Nov 19, 2018

Amejia481 added a commit to Amejia481/android-components that referenced this issue Nov 19, 2018

Amejia481 added a commit to Amejia481/android-components that referenced this issue Nov 19, 2018

Amejia481 added a commit to Amejia481/android-components that referenced this issue Nov 19, 2018

@Amejia481

This comment has been minimized.

Copy link
Contributor Author

commented Nov 19, 2018

@pocmo you hit the nail on the head!
This fix the issue, finally 🙌 !

We can't reuse a geckoSession after a crash 💣 💥 .

        /**
         * The content process hosting this GeckoSession has crashed. The
         * GeckoSession is now closed and unusable. You may call
         * {@link #open(GeckoRuntime)} to recover the session, but no state
         * is preserved. Most applications will want to call
         * {@link #loadUri(Uri)} or {@link #restoreState(SessionState)} at this point.
         *
         * @param session The GeckoSession that crashed.
         */
        void onCrash(GeckoSession session);

Amejia481 added a commit to Amejia481/android-components that referenced this issue Nov 20, 2018

Amejia481 added a commit to Amejia481/android-components that referenced this issue Nov 20, 2018

Amejia481 added a commit to Amejia481/android-components that referenced this issue Nov 20, 2018

Amejia481 added a commit to Amejia481/android-components that referenced this issue Nov 20, 2018

Amejia481 added a commit that referenced this issue Nov 20, 2018

@Amejia481 Amejia481 closed this in 2b4f710 Nov 20, 2018

Android Components Sprint Planning automation moved this from In Progress to Done Nov 20, 2018

@pocmo pocmo added this to the 0.33 🏝️ milestone Nov 21, 2018

pocmo added a commit to pocmo/android-components that referenced this issue Nov 28, 2018

pocmo added a commit to pocmo/android-components that referenced this issue Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.