Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Update search codes #1563

Closed
boek opened this issue Dec 11, 2018 · 6 comments

Comments

3 participants
@boek
Copy link
Member

commented Dec 11, 2018

mozilla-mobile/focus-android#3917

What / Requirements

We need to change our search code for Google. We can do this in a major or minor release.
Acceptance Criteria (how do I know when I’m done?)

New search code sent during searches

Can be done in a major or minor release.

@boek

This comment has been minimized.

Copy link
Member Author

commented Dec 11, 2018

@pocmo

This comment has been minimized.

Copy link
Contributor

commented Dec 17, 2018

@mkaply Over in the Focus issue you mention that for desktop you rename the search plugin as well. What's the reason for that? Search telemetry?

@pocmo

This comment has been minimized.

Copy link
Contributor

commented Dec 17, 2018

@mkaply Also I saw different suffixes (-m, -o). Can you provide more details here? Are those app specific? Is there a way to know which one to pick? Can we use one of them as default for apps using Android Components?

@mkaply

This comment has been minimized.

Copy link

commented Dec 17, 2018

@mkaply Over in the Focus issue you mention that for desktop you rename the search plugin as well. What's the reason for that? Search telemetry?

Telemetry and just to make it perfectly clear we are using the new codes with these engines. I would prefer to change the engine name everywhere to make it clear which code is being used without having to look at the engine contents.

@mkaply Also I saw different suffixes (-m, -o). Can you provide more details here? Are those app specific? Is there a way to know which one to pick? Can we use one of them as default for apps using Android Components?

m = mobile, d=desktop, e = esr, o=other. We get decide what goes in other, but for now I was only classifying Reality as other.

@pocmo pocmo added this to Sprint Backlog in Android Components Sprint Planning Dec 17, 2018

@mkaply

This comment has been minimized.

Copy link

commented Jan 2, 2019

What is the plan with regards to landing this? We want to get this in so that Firefox Reality can switch to the new codes.

We have all the signoffs, so this is ready to go.

sblatz added a commit to sblatz/android-components that referenced this issue Jan 3, 2019

@pocmo pocmo self-assigned this Jan 7, 2019

@pocmo pocmo moved this from Sprint Backlog to In Progress in Android Components Sprint Planning Jan 7, 2019

@pocmo pocmo closed this in 78503a2 Jan 8, 2019

Android Components Sprint Planning automation moved this from In Progress to Done Jan 8, 2019

@pocmo pocmo added this to the 0.37 ☃️ milestone Jan 8, 2019

@pocmo

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2019

0.37.0 will come with the new search codes. In the follow-up (#1667) we will look at migrating the plugin names.

pocmo added a commit that referenced this issue Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.