Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FirefoxAccountsAuthFeature is coupled to "tabs" #2438

Closed
vladikoff opened this issue Mar 20, 2019 · 1 comment
Closed

FirefoxAccountsAuthFeature is coupled to "tabs" #2438

vladikoff opened this issue Mar 20, 2019 · 1 comment

Comments

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Mar 20, 2019

@ryanfeeley is proposing a UI for FxA login in a view that takes over the whole screen (like Firefox iOS). With the current implementation we always do tabsUseCases.addTab.@grigoryk what are your thoughts to let the app decide how to open the FxA login?

cc @csadilek

@grigoryk grigoryk added this to In progress in A-C: Choose What to Sync Aug 1, 2019
@Amejia481
Copy link
Contributor

@Amejia481 Amejia481 commented Aug 15, 2019

This is fixed, now you can provide a lambda for it.

Loading

@Amejia481 Amejia481 closed this Aug 15, 2019
A-C: Choose What to Sync automation moved this from In progress to Done Aug 15, 2019
@pocmo pocmo added this to the 9.0.0 📷 milestone Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants