Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

FirefoxAccountsAuthFeature is coupled to "tabs" #2438

Closed
vladikoff opened this issue Mar 20, 2019 · 1 comment
Closed

FirefoxAccountsAuthFeature is coupled to "tabs" #2438

vladikoff opened this issue Mar 20, 2019 · 1 comment

Comments

@vladikoff
Copy link
Contributor

vladikoff commented Mar 20, 2019

@ryanfeeley is proposing a UI for FxA login in a view that takes over the whole screen (like Firefox iOS). With the current implementation we always do tabsUseCases.addTab.@grigoryk what are your thoughts to let the app decide how to open the FxA login?

cc @csadilek

┆Issue is synchronized with this Jira Task

@grigoryk grigoryk added this to In progress in A-C: Choose What to Sync Aug 1, 2019
@Amejia481
Copy link
Contributor

This is fixed, now you can provide a lambda for it.

A-C: Choose What to Sync automation moved this from In progress to Done Aug 15, 2019
@pocmo pocmo added this to the 9.0.0 📷 milestone Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants