Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display menu builder menu from bottom #3211

Open
sblatz opened this issue May 31, 2019 · 12 comments

Comments

@sblatz
Copy link
Contributor

commented May 31, 2019

For this fenix issue.

We'd like to display the menu builder from the bottom so our most critical menu items are shown even when the whole menu can't be.

@Amejia481

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

@sblatz is this issue the same as #2916?

@sblatz

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

@Amejia481 No, for this issue we're talking about starting the recylcerview of the menu builder from the bottom. For example, if my device is really short, we want to display C before B in the following menu:
A
B
C

@bifleming bifleming added this to ⏳ Sprint Backlog in Android Components Sprint Planning Jun 5, 2019

@Amejia481

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

@sblatz Do you want to mark some BrowserMenuItem as important to let us know that they should be visible always even though that means moving them up in the list order?

@Amejia481

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

Could scroll until the important items are visible could be enough?

@bifleming

This comment has been minimized.

Copy link

commented Jun 6, 2019

@vesta0 ^^

@vesta0

This comment has been minimized.

Copy link

commented Jun 6, 2019

@Amejia481

Current state:
Screenshot_20190606-170223

Ideal state (so back/forward/refresh is visible):
Screenshot_20190606-170230

@vesta0

This comment has been minimized.

Copy link

commented Jun 6, 2019

Ideally, we also want to have an arrow or something indicating that user can scroll up for more options. @mheubusch for post-mvp.

@pocmo

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

@Amejia481 I assume this translates to: For preferred UP direction we scroll all the way down and for preferred DOWN direction we scroll up all the way (or do nothing because that's the default)

@Amejia481

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Just to confirm: @pocmo are you suggesting:

  1. Just using the actual orientation property to do a scroll in the opposite direction (UP -> Scroll down and DOWN -> Scroll up)

  2. Adding a new property for the consumer to indicate which portion of the menu should be always visible when showing.

If option 1 is the preferred. Is this mixing two concepts? The orientation of the menu and the direction that are we going to do scroll if there is not enough space to show all the items? Is this the expected behavior all cases outside of the toolbar menu use case?

@pocmo

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

I was suggesting (1), but yes, I primarily looked at the toolbar and the reference screenshots. For menus in a list like bookmarks that may not be the case and you may always want to show them top to bottom like we do right now. Good catch!

@Amejia481 Amejia481 moved this from ⏳ Sprint Backlog to 🏃‍♀️ In Progress in Android Components Sprint Planning Jun 7, 2019

@Amejia481 Amejia481 self-assigned this Jun 7, 2019

Amejia481 added a commit to Amejia481/android-components that referenced this issue Jun 8, 2019

Amejia481 added a commit to Amejia481/android-components that referenced this issue Jun 8, 2019

Amejia481 added a commit to Amejia481/android-components that referenced this issue Jun 11, 2019

Amejia481 added a commit to Amejia481/android-components that referenced this issue Jun 11, 2019

@Amejia481 Amejia481 closed this in 5b87eca Jun 11, 2019

Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done Jun 11, 2019

@pocmo pocmo added this to the 1.0.0 milestone Jun 11, 2019

@Amejia481 Amejia481 moved this from 🏁 Done to 🏃‍♀️ In Progress in Android Components Sprint Planning Jun 13, 2019

@Amejia481 Amejia481 reopened this Jun 13, 2019

@Amejia481

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

As mentioned on mozilla-mobile/fenix#2219 (comment) this is not working properly on Android 5 & 6 devices, let's take a look.

@vesta0

This comment has been minimized.

Copy link

commented Jun 14, 2019

I am removing MVP blocker since it's only impacting Android 4 & 6.

@vesta0 vesta0 added P1 and removed MVP Blocker labels Jun 14, 2019

Amejia481 added a commit to Amejia481/android-components that referenced this issue Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.