Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve interface to create a FirefoxAccountsAuthFeature #3272

Closed
boek opened this issue Jun 5, 2019 · 1 comment

Comments

@boek
Copy link
Member

commented Jun 5, 2019

Currently the FirefoxAccountsAuthFeature requires a TabUseCase. I would love to be able to provide my own method for dealing with the authURL to better control the auth flow.

see: mozilla-mobile/fenix#3153

@grigoryk

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

LoadUrlUseCase should work well here.

@pocmo pocmo added the 🐉 Fenix label Jun 7, 2019

Amejia481 added a commit to Amejia481/android-components that referenced this issue Aug 1, 2019

Closes mozilla-mobile#3272 and 2438: Improve FirefoxAccountsAuthFeatu…
…re to allow apps

to decide how to open the FxA login.

@grigoryk grigoryk added this to In progress in A-C: Choose What to Sync Aug 1, 2019

Amejia481 added a commit to Amejia481/android-components that referenced this issue Aug 1, 2019

Closes mozilla-mobile#3272 and 2438: Improve FirefoxAccountsAuthFeatu…
…re to allow apps

to decide how to open the FxA login.

grigoryk added a commit to grigoryk/android-components that referenced this issue Aug 2, 2019

Closes mozilla-mobile#3272 and 2438: Make FirefoxAccountsAuthFeature …
…more flexible

This patch allows applications to configure how exactly they want to handle
opening FxA login urls.

Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>

grigoryk added a commit to grigoryk/android-components that referenced this issue Aug 2, 2019

Closes mozilla-mobile#3272 and 2438: Make FirefoxAccountsAuthFeature …
…more flexible

This patch allows applications to configure how exactly they want to handle
opening FxA login urls.

Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>

Amejia481 added a commit to grigoryk/android-components that referenced this issue Aug 2, 2019

Closes mozilla-mobile#3272 and 2438: Make FirefoxAccountsAuthFeature …
…more flexible

This patch allows applications to configure how exactly they want to
handle opening FxA login urls.

@Amejia481 Amejia481 closed this in f391cce Aug 2, 2019

A-C: Choose What to Sync automation moved this from In progress to Done Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.