Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Provide API to get providedDefault from SearchEngineManager #3344

Closed
boek opened this issue Jun 10, 2019 · 1 comment · Fixed by #3350
Closed

Provide API to get providedDefault from SearchEngineManager #3344

boek opened this issue Jun 10, 2019 · 1 comment · Fixed by #3350
Labels
🐉 Fenix Feature needed for Fenix <search> Component: browser-search
Milestone

Comments

@boek
Copy link
Contributor

boek commented Jun 10, 2019

Fenix has a requirement to show the default (not selected) search engine at the top of the list.

I'm using getDefaultSearchEngine with the paramater "." to force the behavior that I need in SearchEngineManager.kt`. But we should get a more explicit API for this behavior

┆Issue is synchronized with this Jira Task

@gabrielluong
Copy link
Member

Hello, I am interested in working on this unless this is already being worked on. Thanks!

gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jun 10, 2019
…rchEngineManager to get the provided default search engine.
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jun 11, 2019
…rchEngineManager to get the provided default search engine.
@pocmo pocmo added <search> Component: browser-search 🐉 Fenix Feature needed for Fenix labels Jun 11, 2019
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jun 11, 2019
…rchEngineManager to get the provided default search engine.
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jun 11, 2019
…rchEngineManager to get the provided default search engine.
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jun 11, 2019
…rchEngineManager to get the provided default search engine.
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jun 11, 2019
…rchEngineManager to get the provided default search engine.
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jun 11, 2019
…rchEngineManager to get the provided default search engine.
pocmo pushed a commit that referenced this issue Jun 12, 2019
…er to get the provided default search engine.
@pocmo pocmo added this to the 1.0.0 milestone Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐉 Fenix Feature needed for Fenix <search> Component: browser-search
Projects
No open projects
3 participants