Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide API to get providedDefault from SearchEngineManager #3344

Closed
boek opened this issue Jun 10, 2019 · 1 comment

Comments

3 participants
@boek
Copy link
Member

commented Jun 10, 2019

Fenix has a requirement to show the default (not selected) search engine at the top of the list.

I'm using getDefaultSearchEngine with the paramater "." to force the behavior that I need in SearchEngineManager.kt`. But we should get a more explicit API for this behavior

@gabrielluong

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

Hello, I am interested in working on this unless this is already being worked on. Thanks!

gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jun 10, 2019

Closes mozilla-mobile#3344: Add getProvidedDefaultSearchEngine to Sea…
…rchEngineManager to get the provided default search engine.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jun 11, 2019

Closes mozilla-mobile#3344: Add getProvidedDefaultSearchEngine to Sea…
…rchEngineManager to get the provided default search engine.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jun 11, 2019

Closes mozilla-mobile#3344: Add getProvidedDefaultSearchEngine to Sea…
…rchEngineManager to get the provided default search engine.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jun 11, 2019

Closes mozilla-mobile#3344: Add getProvidedDefaultSearchEngine to Sea…
…rchEngineManager to get the provided default search engine.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jun 11, 2019

Closes mozilla-mobile#3344: Add getProvidedDefaultSearchEngine to Sea…
…rchEngineManager to get the provided default search engine.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jun 11, 2019

Closes mozilla-mobile#3344: Add getProvidedDefaultSearchEngine to Sea…
…rchEngineManager to get the provided default search engine.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue Jun 11, 2019

Closes mozilla-mobile#3344: Add getProvidedDefaultSearchEngine to Sea…
…rchEngineManager to get the provided default search engine.

@pocmo pocmo closed this in #3350 Jun 12, 2019

pocmo added a commit that referenced this issue Jun 12, 2019

Closes #3344: Add getProvidedDefaultSearchEngine to SearchEngineManag…
…er to get the provided default search engine.

@pocmo pocmo added this to the 1.0.0 milestone Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.