Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving WebserverRule to support-test #3893

Closed
pocmo opened this issue Jul 25, 2019 · 3 comments

Comments

@pocmo
Copy link
Contributor

commented Jul 25, 2019

WebserverRule runs a webserver during tests and serves files from the assets folder in the test package. It's generic enough to be helpful for a bunch of apps.

https://github.com/mozilla-mobile/android-components/blob/master/samples/browser/src/androidTest/java/org/mozilla/samples/browser/rules/WebserverRule.kt

rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 6, 2019

rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 6, 2019

@rocketsroger

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

I'm working on this.

rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 6, 2019

rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 7, 2019

rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 7, 2019

rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 7, 2019

Amejia481 added a commit that referenced this issue Aug 7, 2019

csadilek added a commit to csadilek/android-components that referenced this issue Aug 7, 2019

@csadilek

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

@royang51 unfortunately, your fix here causes the smokeTests to fail:

See TC: https://tools.taskcluster.net/groups/Imn6yolnTneNMS0RSqUFKg/tasks/Xbk07HodQminSpRpAT9-Dw/runs/0/logs/public%2Flogs%2Flive.log

One problem is that we need to use androidTestImplemention instead of testImplementation when declaring the dependency for UI tests. I think we also need to move the WebserverRule to support-android-test (instead of support-test), because we'll get into classpath issues with Robolectric otherwise. You can confirm by running the SmokeTests locally.

We should have caught this in the PR build, but the UI tests don't seem to run for those builds. We'll look into that too.

@rocketsroger

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@csadilek I'll fix this tomorrow morning. Thanks,

rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 8, 2019

rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 8, 2019

csadilek added a commit that referenced this issue Aug 8, 2019

@pocmo pocmo added this to the 8.0.0 🍦 milestone Aug 13, 2019

@pocmo pocmo closed this Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.