Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Consider moving WebserverRule to support-test #3893

Closed
pocmo opened this issue Jul 25, 2019 · 3 comments
Closed

Consider moving WebserverRule to support-test #3893

pocmo opened this issue Jul 25, 2019 · 3 comments
Assignees
Labels
⌨️ code Technical debt, code clean up, small API change .. help wanted Extra attention is needed ✅ testing Unit tests, UI tests and other automated tests
Milestone

Comments

@pocmo
Copy link
Contributor

pocmo commented Jul 25, 2019

WebserverRule runs a webserver during tests and serves files from the assets folder in the test package. It's generic enough to be helpful for a bunch of apps.

https://github.com/mozilla-mobile/android-components/blob/master/samples/browser/src/androidTest/java/org/mozilla/samples/browser/rules/WebserverRule.kt

┆Issue is synchronized with this Jira Task

@pocmo pocmo added ⌨️ code Technical debt, code clean up, small API change .. ✅ testing Unit tests, UI tests and other automated tests help wanted Extra attention is needed labels Jul 25, 2019
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 6, 2019
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 6, 2019
@rocketsroger
Copy link
Contributor

I'm working on this.

rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 6, 2019
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 7, 2019
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 7, 2019
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 7, 2019
csadilek added a commit to csadilek/android-components that referenced this issue Aug 7, 2019
@csadilek
Copy link
Contributor

csadilek commented Aug 7, 2019

@royang51 unfortunately, your fix here causes the smokeTests to fail:

See TC: https://tools.taskcluster.net/groups/Imn6yolnTneNMS0RSqUFKg/tasks/Xbk07HodQminSpRpAT9-Dw/runs/0/logs/public%2Flogs%2Flive.log

One problem is that we need to use androidTestImplemention instead of testImplementation when declaring the dependency for UI tests. I think we also need to move the WebserverRule to support-android-test (instead of support-test), because we'll get into classpath issues with Robolectric otherwise. You can confirm by running the SmokeTests locally.

We should have caught this in the PR build, but the UI tests don't seem to run for those builds. We'll look into that too.

@rocketsroger
Copy link
Contributor

@csadilek I'll fix this tomorrow morning. Thanks,

rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 8, 2019
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 8, 2019
@pocmo pocmo added this to the 8.0.0 🍦 milestone Aug 13, 2019
@pocmo pocmo closed this as completed Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⌨️ code Technical debt, code clean up, small API change .. help wanted Extra attention is needed ✅ testing Unit tests, UI tests and other automated tests
Projects
None yet
Development

No branches or pull requests

3 participants