Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] "Open with" dialogue opens when interacting with website's search #3944

Closed
vesta0 opened this issue Jul 29, 2019 · 2 comments

Comments

@vesta0
Copy link

commented Jul 29, 2019

Steps to reproduce

-Open Fenix and navigate to Amazon.ca
-Type something in the website's search box
-Tap on X to clear the search

(you can also replicate when interacting with website's search on freshcityfarms.com

Expected behavior

Search clears

Actual behavior

Search clears AND Open with browser dialogue opens

Device information

  • Android device: Pixel 3
  • Fenix version: Nightly 190726

Screenshot_20190729-134351

@vesta0 vesta0 added the P1 label Jul 29, 2019

@vesta0 vesta0 changed the title [Bug] Open with dialogue opens when interacting with website's search [Bug] "Open with" dialogue opens when interacting with website's search Jul 29, 2019

@csadilek csadilek added this to ⏳ Sprint Backlog in A-C: Android Components Sprint Planning Jul 29, 2019

@pocmo pocmo self-assigned this Jul 29, 2019

@pocmo pocmo moved this from ⏳ Sprint Backlog to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Jul 30, 2019

@pocmo pocmo added this to In progress in A-C: Android Intent URLs Jul 30, 2019

@pocmo

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

In this case a request for javascript:; gets triggered. One option would be to just ignore the javascript scheme. But I'll explore some other options first.

pocmo added a commit to pocmo/android-components that referenced this issue Jul 30, 2019

pocmo added a commit to pocmo/android-components that referenced this issue Jul 30, 2019

Closes mozilla-mobile#3944: AppLinksFeature: Do not open third-party …
…apps for URLs with javascript scheme.

@pocmo pocmo added this to the 7.0.0 milestone Jul 30, 2019

pocmo added a commit to pocmo/android-components that referenced this issue Jul 30, 2019

pocmo added a commit to pocmo/android-components that referenced this issue Jul 30, 2019

Closes mozilla-mobile#3944: AppLinksFeature: Do not open third-party …
…apps for URLs with javascript scheme.

A-C: Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done Jul 30, 2019

pocmo added a commit that referenced this issue Jul 31, 2019

@pocmo

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

I'll trigger the AC 6.0.1 release build now to get that out for the next Fenix release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.