Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CrashReporter to engine abstraction #4052

Closed
jonalmeida opened this issue Aug 7, 2019 · 2 comments
Closed

Move CrashReporter to engine abstraction #4052

jonalmeida opened this issue Aug 7, 2019 · 2 comments

Comments

@jonalmeida
Copy link
Contributor

@jonalmeida jonalmeida commented Aug 7, 2019

We use the Gecko CrashReporter directly in lib-crash and compile it against GeckoView Nightly only. This lead to a breaking API change on the crash report that exists in nightly but not in beta/release.

Since the crash reporter doesn't have the powers of the engine abstraction we've built for the different variants of Gecko, we had to put in a hacky change that fixes this those versions.

What we should do is to abstract out the crash reporter into the engine so that we can avoid this issue in the future (and also remove our original patch).

@pocmo
Copy link
Contributor

@pocmo pocmo commented Aug 12, 2019

Looks like a duplicate of #2203

Loading

@jonalmeida
Copy link
Contributor Author

@jonalmeida jonalmeida commented Aug 12, 2019

Closing!

Loading

@jonalmeida jonalmeida closed this Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants