Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Pass (at least) Session to Session.Observer methods #406

@pocmo

Description

@pocmo

Our Session.Observer interfaces currently looks like this:

    interface Observer {
        fun onUrlChanged() = Unit
        fun onProgress() = Unit
        fun onLoadingStateChanged() = Unit
        fun onNavigationStateChanged() = Unit
        fun onSearch() = Unit
        fun onSecurityChanged() = Unit
        fun onCustomTabConfigChanged() = Unit
    }

It would be helpful if we at least pass the Session object to those methods. Otherwise it's sometimes cumbersome to get the Session instance from inside the observer.

┆Issue is synchronized with this Jira Task

Metadata

Metadata

Assignees

Labels

<session>Component: browser-session🌟 featureNew functionality and improvements

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions