Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe Browsing isn't a TrackingProtectionPolicy (in TrackingProtectionPolicy.select) #4190

Closed
mcomella opened this issue Aug 22, 2019 · 5 comments
Closed

Comments

@mcomella
Copy link
Contributor

@mcomella mcomella commented Aug 22, 2019

In TrackingProtectionPolicy.select, there are three arguments:

  • trackingCategories
  • safeBrowsingCategories
  • cookiePolicy

afaik, 2 of these help with blocking trackers; the other, Safe Browsing, does not help with blocking trackers.

Most users probably never want to disable safe browsing: there's minimal risk to having it enabled (afaik, comparison happens locally) and having it disabled just opens them up to risks. This creates a problem: if you want to use the "defaults" to enable and disable tracking protection:

if (hasUserEnabledTrackingProtection) {
    TrackingProtectionPolicy.recommended()
} else {
    TrackingProtectionPolicy.none()
}

The user ends up disabling safe browsing when they disable tracking protection: this is unintuitive and probably not desired by the user.

My recommendation: make safe browsing a separate setting from the tracking protection policy.

CC @pocmo this seems like a serious issue to me.

@pocmo
Copy link
Contributor

@pocmo pocmo commented Aug 23, 2019

Loading

@Amejia481
Copy link
Contributor

@Amejia481 Amejia481 commented Aug 23, 2019

On it!

Loading

@Amejia481
Copy link
Contributor

@Amejia481 Amejia481 commented Aug 23, 2019

My recommendation: make safe browsing a separate setting from the tracking protection policy.

Agree with @mcomella comments 👍
Working on dividing the API, thanks for raising this issue!

Loading

@pocmo
Copy link
Contributor

@pocmo pocmo commented Aug 23, 2019

@Amejia481 Do you want to move that into the sprint / on the board?

Loading

@Amejia481
Copy link
Contributor

@Amejia481 Amejia481 commented Aug 23, 2019

Yes thanks!

Loading

@Amejia481 Amejia481 added this to ⏳ Sprint Backlog in A-C: Android Components Sprint Planning Aug 23, 2019
@Amejia481 Amejia481 moved this from ⏳ Sprint Backlog to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Aug 23, 2019
Amejia481 added a commit to Amejia481/android-components that referenced this issue Aug 26, 2019
Amejia481 added a commit to Amejia481/android-components that referenced this issue Aug 26, 2019
@jonalmeida jonalmeida added this to the 10.0.0 🏊 milestone Aug 26, 2019
bors bot pushed a commit that referenced this issue Aug 27, 2019
4211: Closes #4190: Decouple safe browsing api from the tracking protection. r=Amejia481 a=Amejia481



Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
@bors bors bot closed this in 4b0a42e Aug 27, 2019
A-C: Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done Aug 27, 2019
NotWoods added a commit to NotWoods/android-components that referenced this issue Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants