Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for safe browsing on SystemEngine #4206

Open
Amejia481 opened this issue Aug 26, 2019 · 4 comments
Open

Add support for safe browsing on SystemEngine #4206

Amejia481 opened this issue Aug 26, 2019 · 4 comments

Comments

@Amejia481
Copy link
Contributor

@Amejia481 Amejia481 commented Aug 26, 2019

GeckoView comes out the box with support for safe browsing. On SystemEngine we have to provide our own implementation.

@pocmo
Copy link
Contributor

@pocmo pocmo commented Aug 26, 2019

WebView supports safe browsing too!

@Amejia481
Copy link
Contributor Author

@Amejia481 Amejia481 commented Aug 26, 2019

Oh nice, I didn't know that. Then we just have to activate depending on which policy the users select

@Amejia481
Copy link
Contributor Author

@Amejia481 Amejia481 commented Aug 26, 2019

Looks like is supported from Android 8.0 (API level 26) and above 😞

Developers of Android apps using WebView no longer have to make any changes to benefit from this protection. Safe Browsing in WebView has been available since Android 8.0 (API level 26), using the same underlying technology as Chrome on Android. When Safe Browsing is triggered, the app will present a warning and receive a network error. Apps built for API level 27 and above can customize this behavior with new APIs for Safe Browsing.

@Amejia481
Copy link
Contributor Author

@Amejia481 Amejia481 commented Aug 26, 2019

The webview implementation doesn't allow to provide a granular control as geckoview does, like providing which specific threat the users want to enable or disable, it only allows to enable it or disable it WebSettings.html#setSafeBrowsingEnabled(boolean) and it's only available from API level 26 at least user can enable it on lower APIs using a manifest tag

@data-sync-user data-sync-user changed the title Add support for safe browsing on SystemEngine FNX3-22419 ⁃ Add support for safe browsing on SystemEngine Aug 2, 2020
@data-sync-user data-sync-user changed the title FNX3-22419 ⁃ Add support for safe browsing on SystemEngine FNX2-16875 ⁃ Add support for safe browsing on SystemEngine Aug 2, 2020
@st3fan st3fan changed the title FNX2-16875 ⁃ Add support for safe browsing on SystemEngine Add support for safe browsing on SystemEngine Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants