Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing app data does not reset the registration ID in ADM #4458

Closed
jonalmeida opened this issue Sep 19, 2019 · 0 comments

Comments

@jonalmeida
Copy link
Member

commented Sep 19, 2019

When you clear app data, the assumption was that the app's registration token for the push service should be removed as well.

This is however not the case since the ADM instance is local to the device and not to the app, we can receive a cached version.

Usually this wouldn't matter, but it seems like we were never handling that case.

@jonalmeida jonalmeida created this issue from a note in A-C: Meta: Send Tab Components (In Progress) Sep 19, 2019
@jonalmeida jonalmeida self-assigned this Sep 19, 2019
jonalmeida added a commit that referenced this issue Sep 19, 2019
Since the ADM instance does not live in the app itself, clearing app
data doesn't remove the registration ID for it. This means that we never
initialize the native PushManager with the cached code.

Our fix is straight-forward: if we have a cached registration ID, invoke
the `PushProcessor#onNewToken` and follow the regular flow.
@jonalmeida jonalmeida added this to the 14.0.0 🔭 milestone Sep 19, 2019
bors bot pushed a commit that referenced this issue Sep 19, 2019
Merge #4459
4459: Closes #4458: Use cached registration token from ADM if available r=Amejia481 a=jonalmeida

Since the ADM instance does not live in the app itself, clearing app
data doesn't remove the registration ID for it. This means that we never
initialize the native PushManager with the cached code.

Our fix is straight-forward: if we have a cached registration ID, invoke
the `PushProcessor#onNewToken` and follow the regular flow.




Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
bors bot pushed a commit that referenced this issue Sep 19, 2019
4459: Closes #4458: Use cached registration token from ADM if available r=Amejia481 a=jonalmeida

Since the ADM instance does not live in the app itself, clearing app
data doesn't remove the registration ID for it. This means that we never
initialize the native PushManager with the cached code.

Our fix is straight-forward: if we have a cached registration ID, invoke
the `PushProcessor#onNewToken` and follow the regular flow.




4471: Promote Logins to production ready component [ci skip] r=Amejia481 a=vladikoff

We ship it in Lockwise and soon Fenix...


Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
Co-authored-by: Vlad Filippov <vlad.filippov@gmail.com>
@bors bors bot closed this in 4c0122a Sep 19, 2019
A-C: Meta: Send Tab Components automation moved this from In Progress to Done Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.