Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Clearing app data does not reset the registration ID in ADM #4458

Closed
jonalmeida opened this issue Sep 19, 2019 · 0 comments
Closed

Clearing app data does not reset the registration ID in ADM #4458

jonalmeida opened this issue Sep 19, 2019 · 0 comments
Assignees
@jonalmeida
Labels
<push> Components: concept-push, lib-push-adm, lib-push-firebase, feature-push, feature-sendtab
Milestone
14.0.0 🔭

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Sep 19, 2019 •
edited by data-sync-user
Loading

When you clear app data, the assumption was that the app's registration token for the push service should be removed as well.

This is however not the case since the ADM instance is local to the device and not to the app, we can receive a cached version.

Usually this wouldn't matter, but it seems like we were never handling that case.

┆Issue is synchronized with this Jira Task
@jonalmeida jonalmeida self-assigned this Sep 19, 2019
@jonalmeida jonalmeida added <push> Components: concept-push, lib-push-adm, lib-push-firebase, feature-push, feature-sendtab 📺 Fire TV labels Sep 19, 2019
jonalmeida added a commit that referenced this issue Sep 19, 2019
@jonalmeida
Closes #4458: Use cached registration token from ADM if available
3ccb7dc 
Since the ADM instance does not live in the app itself, clearing app
data doesn't remove the registration ID for it. This means that we never
initialize the native PushManager with the cached code.

Our fix is straight-forward: if we have a cached registration ID, invoke
the `PushProcessor#onNewToken` and follow the regular flow.
@jonalmeida jonalmeida added this to the 14.0.0 🔭 milestone Sep 19, 2019
bors bot pushed a commit that referenced this issue Sep 19, 2019
@MozLando @jonalmeida
Merge #4459
ae18706 
4459: Closes #4458: Use cached registration token from ADM if available r=Amejia481 a=jonalmeida

Since the ADM instance does not live in the app itself, clearing app
data doesn't remove the registration ID for it. This means that we never
initialize the native PushManager with the cached code.

Our fix is straight-forward: if we have a cached registration ID, invoke
the `PushProcessor#onNewToken` and follow the regular flow.




Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
bors bot pushed a commit that referenced this issue Sep 19, 2019
@MozLando @jonalmeida @vladikoff
Merge #4459 #4471
408b7b4 
4459: Closes #4458: Use cached registration token from ADM if available r=Amejia481 a=jonalmeida

Since the ADM instance does not live in the app itself, clearing app
data doesn't remove the registration ID for it. This means that we never
initialize the native PushManager with the cached code.

Our fix is straight-forward: if we have a cached registration ID, invoke
the `PushProcessor#onNewToken` and follow the regular flow.




4471: Promote Logins to production ready component [ci skip] r=Amejia481 a=vladikoff

We ship it in Lockwise and soon Fenix...


Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
Co-authored-by: Vlad Filippov <vlad.filippov@gmail.com>
@bors bors bot closed this as completed in 4c0122a Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonalmeida jonalmeida

Labels
<push> Components: concept-push, lib-push-adm, lib-push-firebase, feature-push, feature-sendtab
Projects
None yet
Milestone
14.0.0 🔭
Development

No branches or pull requests
1 participant
@jonalmeida