Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Re-size icons in the toolbar #4490
Issues to address:
1. Reduced visibility of the URL
As we added the new tracking protection icon on the toolbar, we didn't distributed the space accordingly to not affect the visible portion of the url.
2. Unused space on the three dotted menu
The three dot menu has a lot of unused space, as you can see in the image below
The issue here is that we are doubling the padding, between the right tab counter and left three dotted menu, creating a huge gap between them.
This is caused because the tab counter adds the same amount of padding to the right as the three dotted menu adds to the left ( tab counter right padding 16dp + three dotted menu left padding 16dp = 32dp padding between them instead of 16dp).
3. Better distribution of the space on custom tabs
As you can seen in the image below we are not doing a smart use for the space in custom tab, there is a lot of space that can be redistributed, to show more url and title.
4478: Closes #4490: Resized icons on the toolbar. r=rocketsroger a=Amejia481 Related #1514 **Updated pics** **Now** ![image](https://user-images.githubusercontent.com/773158/65361730-ab982200-dbd2-11e9-813c-1f2356bc6ab7.png) **Before** ![image](https://user-images.githubusercontent.com/773158/65298766-b30bec80-db3a-11e9-84fa-563064c544c4.png) **Now** ![image](https://user-images.githubusercontent.com/773158/65361694-85728200-dbd2-11e9-956d-f18e9b36fb90.png) **Before** ![image](https://user-images.githubusercontent.com/773158/65298856-1138cf80-db3b-11e9-88e6-0ccd1f093616.png) Co-authored-by: Arturo Mejia <email@example.com>