Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Re-size icons in the toolbar #4490

Closed
Amejia481 opened this issue Sep 20, 2019 · 0 comments
Closed

Re-size icons in the toolbar #4490

Amejia481 opened this issue Sep 20, 2019 · 0 comments
Assignees
Labels
<customtabs> Component: feature-customtabs <toolbar> Components: browser-toolbar, concept-toolbar
Milestone

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Sep 20, 2019

Issues to address:

  1. Reduced visibility of the URL
  2. Unused space on the three dotted menu
  3. Better distribution of the space on custom tabs

1. Reduced visibility of the URL

As we added the new tracking protection icon on the toolbar, we didn't distributed the space accordingly to not affect the visible portion of the url.

Fennec vs Fenix on OnePlus 5T (the red lines represent 25% and 75% of total width)
image
image


2. Unused space on the three dotted menu

The three dot menu has a lot of unused space, as you can see in the image below

image

The issue here is that we are doubling the padding, between the right tab counter and left three dotted menu, creating a huge gap between them.

image

This is caused because the tab counter adds the same amount of padding to the right as the three dotted menu adds to the left ( tab counter right padding 16dp + three dotted menu left padding 16dp = 32dp padding between them instead of 16dp).


3. Better distribution of the space on custom tabs

As you can seen in the image below we are not doing a smart use for the space in custom tab, there is a lot of space that can be redistributed, to show more url and title.

image

Related issues: mozilla-mobile/fenix#4560, mozilla-mobile/fenix#3727 and mozilla-mobile/fenix#5480

┆Issue is synchronized with this Jira Task

@Amejia481 Amejia481 added <toolbar> Components: browser-toolbar, concept-toolbar <customtabs> Component: feature-customtabs labels Sep 20, 2019
@Amejia481 Amejia481 self-assigned this Sep 23, 2019
@bors bors bot closed this as completed in 869cfe3 Sep 23, 2019
@Amejia481 Amejia481 added this to the 14.0.0 🔭 milestone Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
<customtabs> Component: feature-customtabs <toolbar> Components: browser-toolbar, concept-toolbar
Projects
None yet
Development

No branches or pull requests

1 participant