Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Do not save/restore parent tab ID for collections #4514

Closed
csadilek opened this issue Sep 24, 2019 · 0 comments
Closed

Do not save/restore parent tab ID for collections #4514

csadilek opened this issue Sep 24, 2019 · 0 comments
Assignees
@csadilek
Labels
🐞 bug Something isn't working <collections>
Milestone
⛑ 15.0.0

Comments

@csadilek
Copy link
Contributor

csadilek commented Sep 24, 2019 •
edited by data-sync-user
Loading

Tabs in a collection do not have a parent/child relationship and keeping the parent ID can cause problems when opening tabs from collections e.g. the parent could've been removed. See: mozilla-mobile/fenix#5486

┆Issue is synchronized with this Jira Task
@csadilek csadilek added 🐞 bug Something isn't working <collections> labels Sep 24, 2019
@csadilek csadilek self-assigned this Sep 24, 2019
@pocmo pocmo added this to the 15.0.0 milestone Sep 24, 2019
bors bot pushed a commit that referenced this issue Sep 24, 2019
@MozLando @csadilek
Merge #4519
44b01aa 
4519: Closes #4514: Do not restore parent tab ID for collections r=pocmo a=csadilek



Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
@bors bors bot closed this as completed in f1a2a71 Sep 24, 2019
csadilek added a commit that referenced this issue Sep 24, 2019
@csadilek
Closes #4514: Do not restore parent tab ID for collections
81385d7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@csadilek csadilek

Labels
🐞 bug Something isn't working <collections>
Projects
None yet
Milestone
⛑ 15.0.0
Development

No branches or pull requests
2 participants
@pocmo @csadilek