Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not save/restore parent tab ID for collections #4514

Closed
csadilek opened this issue Sep 24, 2019 · 0 comments

Comments

@csadilek
Copy link
Contributor

commented Sep 24, 2019

Tabs in a collection do not have a parent/child relationship and keeping the parent ID can cause problems when opening tabs from collections e.g. the parent could've been removed. See: mozilla-mobile/fenix#5486

@csadilek csadilek self-assigned this Sep 24, 2019
@csadilek csadilek added this to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Sep 24, 2019
@pocmo pocmo added this to the 15.0.0 milestone Sep 24, 2019
bors bot pushed a commit that referenced this issue Sep 24, 2019
Merge #4519
4519: Closes #4514: Do not restore parent tab ID for collections r=pocmo a=csadilek



Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
@bors bors bot closed this in f1a2a71 Sep 24, 2019
A-C: Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done Sep 24, 2019
csadilek added a commit that referenced this issue Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.