Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Crash in java.util.NoSuchElementException: at mozilla.components.feature.push.AutoPushFeature$onMessageReceived$1.invokeSuspend(AutoPushFeature.kt:27) #5134

Closed
mozillamarcia opened this issue Nov 22, 2019 · 3 comments
Closed

Crash in java.util.NoSuchElementException: at mozilla.components.feature.push.AutoPushFeature$onMessageReceived$1.invokeSuspend(AutoPushFeature.kt:27) #5134

mozillamarcia opened this issue Nov 22, 2019 · 3 comments
Assignees
@jonalmeida
Labels
🐞 bug Something isn't working <migration> Component: support-migration <push> Components: concept-push, lib-push-adm, lib-push-firebase, feature-push, feature-sendtab
Projects
A-C: WebNotification & WebPush Fennec migration

Comments

@mozillamarcia
Copy link

mozillamarcia commented Nov 22, 2019 •
edited by data-sync-user

Seen while looking at Fenix nightly crash stats. #4 overall: https://bit.ly/2XANCKm

java.util.NoSuchElementException: Array contains no element matching the predicate.
	at mozilla.components.feature.push.AutoPushFeature$onMessageReceived$1.invokeSuspend(AutoPushFeature.kt:27)
	at mozilla.components.feature.push.AutoPushFeature$onMessageReceived$1.invoke(Unknown Source:10)
	at mozilla.components.feature.push.AutoPushFeatureKt$launchAndTry$1.invokeSuspend(AutoPushFeature.kt:5)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:2)
	at kotlinx.coroutines.DispatchedTask.run(Dispatched.kt:15)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:764)

┆Issue is synchronized with this Jira Task
@csadilek csadilek added the 🐞 bug Something isn't working label Nov 22, 2019
@pocmo pocmo added the <push> Components: concept-push, lib-push-adm, lib-push-firebase, feature-push, feature-sendtab label Nov 25, 2019
@jonalmeida jonalmeida self-assigned this Nov 25, 2019
@grigoryk grigoryk mentioned this issue Nov 26, 2019
Closed
@jonalmeida
Copy link
Contributor

jonalmeida commented Nov 29, 2019 •
edited

There's a strong relation between this and mozilla-mobile/fenix#6663

Turns out this is might be related to some Fennec migration issues.

@jonalmeida jonalmeida moved this from ⏳ Sprint Backlog to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Nov 29, 2019
@jonalmeida
Copy link
Contributor

This should go away when we have better support for multiple scoped UUIDs.

@jonalmeida jonalmeida removed this from 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Dec 2, 2019
grigoryk pushed a commit to grigoryk/android-components that referenced this issue Dec 4, 2019
Closes mozilla-mobile#5134 - Defensive PushType lookup from the incom…
67046a5 
…ing channelId

'channelId' comes to us from the "outside world", so to speak - as part of an
incoming push message. Don't crash in case we couldn't map it to a PushType.
@grigoryk grigoryk added the <migration> Component: support-migration label Dec 4, 2019
@grigoryk grigoryk added this to In progress in Fennec migration Dec 4, 2019
grigoryk pushed a commit to grigoryk/android-components that referenced this issue Dec 4, 2019
Closes mozilla-mobile#5134 - Defensive PushType lookup from the incom…
b3516e5 
…ing channelId

'channelId' comes to us from the "outside world", so to speak - as part of an
incoming push message. Don't crash in case we couldn't map it to a PushType.
bors bot pushed a commit that referenced this issue Dec 4, 2019
@MozLando
Merge #5232
5c55096 
5232: Closes #5134 - Defensive PushType lookup from the incoming channelId r=jonalmeida a=grigoryk

`channelId` comes to us from the "outside world", so to speak - as part of an
incoming push message. Don't crash in case we couldn't map it to a PushType.

@jonalmeida what do you think? I reckon we need to do something like this regardless of migration crashes - but it's particularly annoying with those :)



Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
@bors bors bot closed this as completed in 6144810 Dec 4, 2019
Fennec migration automation moved this from In progress to Ready for QA Dec 4, 2019
A-C: WebNotification & WebPush automation moved this from Backlog to Done Dec 4, 2019
@ebalazs-sv
Copy link

ebalazs-sv commented Dec 16, 2019 •
edited

Verified as fixed.
There are no more crashes with this signature in Fenix crash stats starting with the 4th of December.
I will mark this as Done.

@ebalazs-sv ebalazs-sv moved this from Ready for QA to Done in Fennec migration Dec 16, 2019
sblatz pushed a commit to sblatz/android-components that referenced this issue Dec 19, 2019
@sblatz
Closes mozilla-mobile#5134 - Defensive PushType lookup from the incom…
018d848 
…ing channelId

'channelId' comes to us from the "outside world", so to speak - as part of an
incoming push message. Don't crash in case we couldn't map it to a PushType.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonalmeida jonalmeida

Labels
🐞 bug Something isn't working <migration> Component: support-migration <push> Components: concept-push, lib-push-adm, lib-push-firebase, feature-push, feature-sendtab
Projects
No open projects
A-C: WebNotification & WebPush
  
Done
Fennec migration
  
Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pocmo @grigoryk @csadilek @jonalmeida @mozillamarcia @ebalazs-sv