Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash IllegalArgumentException: Unsupported URI scheme when downloading icon #7142

Closed
ekager opened this issue May 28, 2020 · 2 comments · Fixed by #7160
Closed

Crash IllegalArgumentException: Unsupported URI scheme when downloading icon #7142

ekager opened this issue May 28, 2020 · 2 comments · Fixed by #7160
Assignees
Labels
💥 crash E5 <fetch> <icons>

Comments

@ekager
Copy link
Contributor

ekager commented May 28, 2020

Originally reported here: mozilla-mobile/fenix#10880

Steps to reproduce

Visit https://www.gruppoapi.com/ricerca-stazioni-servizio

2020-05-27 20:00:14.677 9383-9590/org.mozilla.fenix.debug D/HttpIconLoader: IllegalArgumentException while trying to download icon resource https://www.gruppoapi.com/ricerca-stazioni-servizio/images/logo-gruppoapi-shared.png

java.lang.IllegalArgumentException: Unsupported URI scheme
    at org.mozilla.geckoview.GeckoWebExecutor.fetch(GeckoWebExecutor.java:128)
    at mozilla.components.browser.engine.gecko.fetch.GeckoViewFetchClient.fetch(GeckoViewFetchClient.kt:64)
    at mozilla.components.browser.icons.loader.HttpIconLoader.load(HttpIconLoader.kt:54)
    at mozilla.components.browser.icons.BrowserIconsKt.load(BrowserIcons.kt:276)
    at mozilla.components.browser.icons.BrowserIconsKt.access$load(BrowserIcons.kt:1)
    at mozilla.components.browser.icons.BrowserIcons.loadIconInternal(BrowserIcons.kt:127)
    at mozilla.components.browser.icons.BrowserIcons.access$loadIconInternal(BrowserIcons.kt:77)
    at mozilla.components.browser.icons.BrowserIcons$loadIcon$1.invokeSuspend(BrowserIcons.kt:110)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
    at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:56)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
    at java.lang.Thread.run(Thread.java:919)

I confirmed catching the IllegalArgumentException in HttpIconLoader fixes this, which we should probably do because crashing on fetching icons seems silly, but I thought this was interesting to bring up before catching it because it's unclear to me why this website would be an Unsupported URI scheme.

┆Issue is synchronized with this Jira Task

@ekager ekager added <icons> <fetch> 💥 crash labels May 28, 2020
@ekager ekager added this to Backlog in Fenix:AC Bugs via automation May 28, 2020
@ekager ekager moved this from Backlog to Top 10 in Fenix:AC Bugs May 28, 2020
@Amejia481 Amejia481 added this to Backlog in Fenix: Downloads May 28, 2020
@Amejia481 Amejia481 self-assigned this May 28, 2020
@Amejia481 Amejia481 moved this from Backlog to In progress in Fenix: Downloads May 28, 2020
@Amejia481 Amejia481 added this to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning May 28, 2020
@Amejia481
Copy link
Contributor

Amejia481 commented May 28, 2020

Amejia481 added a commit to Amejia481/android-components that referenced this issue May 28, 2020
@Amejia481 Amejia481 added the E3 label May 28, 2020
@Amejia481
Copy link
Contributor

Amejia481 commented May 28, 2020

Amejia481 added a commit to Amejia481/android-components that referenced this issue Jun 1, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Jun 1, 2020
@Amejia481 Amejia481 added this to the 44.0.0 milestone Jun 1, 2020
@Amejia481 Amejia481 linked a pull request Jun 1, 2020 that will close this issue
4 tasks
@Amejia481 Amejia481 moved this from Top 10 to In Progress in Fenix:AC Bugs Jun 1, 2020
@pocmo pocmo modified the milestones: 44.0.0, 45.0.0 Jun 2, 2020
@Amejia481 Amejia481 added E5 and removed E3 labels Jun 3, 2020
bors bot pushed a commit that referenced this issue Jun 3, 2020
7160:  Closes #7142: Sanitize url in HttpIconLoader  r=pocmo a=Amejia481



Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
bors bot pushed a commit that referenced this issue Jun 3, 2020
7160:  Closes #7142: Sanitize url in HttpIconLoader  r=pocmo a=Amejia481



7196: Closes #7176: Add to the configuration file for instrumentation tests components that use Room r=gabrielluong,pocmo,isabelrios a=Amejia481

Closes #7176


Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
@bors bors bot closed this as completed in 98158c8 Jun 3, 2020
A-C: Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done Jun 3, 2020
Fenix:AC Bugs automation moved this from In Progress to Done Jun 3, 2020
@Amejia481 Amejia481 moved this from In progress to Done in Fenix: Downloads Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 crash E5 <fetch> <icons>
Development

Successfully merging a pull request may close this issue.

3 participants