Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not redirect to market app if app is already installed #8122

Closed
rocketsroger opened this issue Aug 14, 2020 · 1 comment
Closed

Do not redirect to market app if app is already installed #8122

rocketsroger opened this issue Aug 14, 2020 · 1 comment
Assignees
Labels
<app-links> Component: feature-app-links E5 Estimation points: 5
Milestone

Comments

@rocketsroger
Copy link
Contributor

rocketsroger commented Aug 14, 2020

Currently if app links failed to open the intent in an external app will fall back to the market intent. This is with the assumption that if intent failed and target package exists, the app is not installed.

However, some site trying to redirect the intent to their app without correctly setting the intent filter on the app side. If intent failed to launch and the package is already installed, use the fall back URL because something is wrong with the external app.

┆Issue is synchronized with this Jira Task

@rocketsroger rocketsroger added E3 Estimation points: 3 <app-links> Component: feature-app-links labels Aug 14, 2020
@rocketsroger rocketsroger self-assigned this Aug 14, 2020
@rocketsroger
Copy link
Contributor Author

rocketsroger commented Aug 14, 2020

Related: mozilla-mobile/fenix#12746

@rocketsroger rocketsroger added E5 Estimation points: 5 and removed E3 Estimation points: 3 labels Aug 14, 2020
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 14, 2020
@rocketsroger rocketsroger added this to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Aug 14, 2020
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 17, 2020
bors bot pushed a commit that referenced this issue Aug 17, 2020
8126: Closes #8122: Do not redirect to market app if app is already installed r=Amejia481 a=rocketsroger



Co-authored-by: Roger Yang <royang@mozilla.com>
@bors bors bot closed this as completed in cf408af Aug 17, 2020
A-C: Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done Aug 17, 2020
@Amejia481 Amejia481 added this to the 55.0.0 💨 milestone Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<app-links> Component: feature-app-links E5 Estimation points: 5
Development

No branches or pull requests

2 participants