Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IllegalStateException: Fragment already added: SimpleRedirectDialogFragment (SHOULD_OPEN_APP_LINK_PROMPT_DIALOG) #8169

Closed
csadilek opened this issue Aug 20, 2020 · 4 comments
Assignees
Labels
<app-links> Component: feature-app-links 🐞 bug Something isn't working 💥 crash E2 Estimation points: 2
Milestone

Comments

@csadilek
Copy link
Contributor

csadilek commented Aug 20, 2020

This is similar to the crash we had for the download fragment, but app links and low volume:

java.lang.IllegalStateException: Fragment already added: SimpleRedirectDialogFragment{65faa78} (b29aa62f-8d58-4e3f-9f09-70ab965f46c7) SHOULD_OPEN_APP_LINK_PROMPT_DIALOG}
    at androidx.fragment.app.FragmentStore.addFragment(FragmentStore.java:7)
    at androidx.fragment.app.FragmentManager.addFragment(FragmentManager.java:4)
    at androidx.fragment.app.BackStackRecord.executeOps(BackStackRecord.java:24)
    at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:51)
    at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:10)
    at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:4)
    at androidx.fragment.app.FragmentManager$4.run(FragmentManager.java:1)
    at android.os.Handler.handleCallback(Handler.java:751)
    at android.os.Handler.dispatchMessage(Handler.java:95)
    at android.os.Looper.TinnoLoop(Looper.java:150)
    at android.os.Looper.loop(Looper.java:208)
    at android.app.ActivityThread.main(ActivityThread.java:6175)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)

┆Issue is synchronized with this Jira Task

@csadilek csadilek added 🐞 bug Something isn't working <app-links> Component: feature-app-links 💥 crash labels Aug 20, 2020
@csadilek
Copy link
Contributor Author

csadilek commented Aug 20, 2020

@rocketsroger
Copy link
Contributor

rocketsroger commented Aug 20, 2020

Sentry: https://sentry.prod.mozaws.net/operations/firefox/issues/9367623/

/cc @rocketsroger

Thanks, I'll take a look

@rocketsroger rocketsroger self-assigned this Aug 20, 2020
@rocketsroger rocketsroger added this to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Aug 20, 2020
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 20, 2020
@rocketsroger rocketsroger added the E2 Estimation points: 2 label Aug 20, 2020
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Aug 20, 2020
bors bot pushed a commit that referenced this issue Aug 21, 2020
8177: Closes #8169: Immediately show redirect dialog fragment r=jonalmeida a=rocketsroger



Co-authored-by: Roger Yang <royang@mozilla.com>
@bors bors bot closed this as completed in 0715503 Aug 21, 2020
A-C: Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done Aug 21, 2020
@rocketsroger rocketsroger added this to the 56.0.0 milestone Aug 21, 2020
@parthanjaria
Copy link

parthanjaria commented Oct 22, 2021

is the issue resolved?

@rocketsroger
Copy link
Contributor

rocketsroger commented Apr 4, 2022

is the issue resolved?

Yes, AFAIK this had been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<app-links> Component: feature-app-links 🐞 bug Something isn't working 💥 crash E2 Estimation points: 2
Development

No branches or pull requests

3 participants