Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharePrompt: RuntimeException Cannot confirm/dismiss a Prompt twice #8240

Closed
Amejia481 opened this issue Aug 26, 2020 · 0 comments · Fixed by #8244
Closed

SharePrompt: RuntimeException Cannot confirm/dismiss a Prompt twice #8240

Amejia481 opened this issue Aug 26, 2020 · 0 comments · Fixed by #8244
Assignees
Labels
💥 crash E3 Estimation points: 3 <prompts> Component: feature-prompts
Milestone

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Aug 26, 2020

https://sentry.prod.mozaws.net/operations/firefox/issues/9257357

java.lang.RuntimeException: Cannot confirm/dismiss a Prompt twice.
    at org.mozilla.geckoview.GeckoSession$PromptDelegate$BasePrompt.dismiss(GeckoSession.java:4)
    at org.mozilla.geckoview.GeckoSession$PromptDelegate$SharePrompt.dismiss(GeckoSession.java:2)
    at mozilla.components.browser.engine.gecko.prompt.-$$LambdaGroup$ks$8u4bVLX0p_V5ID86K2iFOrsJPms.invoke(com.android.tools.r8.jetbrains.kotlin-style lambda group:7)
    at org.mozilla.fenix.share.ShareFragment.dismiss(ShareFragment.kt:8)
    at androidx.navigation.fragment.DialogFragmentNavigator.popBackStack(DialogFragmentNavigator.java:7)
    at androidx.navigation.NavController.popBackStackInternal(NavController.java:15)
    at androidx.navigation.NavController.popBackStack(NavController.java:3)
    at androidx.navigation.NavController.popBackStack(NavController.java:2)
    at androidx.navigation.fragment.DialogFragmentNavigator$1.onStateChanged(DialogFragmentNavigator.java:4)
    at androidx.lifecycle.LifecycleRegistry$ObserverWithState.dispatchEvent(LifecycleRegistry.java:3)
    at androidx.lifecycle.LifecycleRegistry.backwardPass(LifecycleRegistry.java:10)
    at androidx.lifecycle.LifecycleRegistry.sync(LifecycleRegistry.java:5)
    at androidx.lifecycle.LifecycleRegistry.moveToState(LifecycleRegistry.java:5)
    at androidx.lifecycle.LifecycleRegistry.handleLifecycleEvent(LifecycleRegistry.java:2)
    at androidx.fragment.app.Fragment.performStop(Fragment.java:4)
    at androidx.fragment.app.FragmentStateManager.stop(FragmentStateManager.java:3)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:31)
    at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState(FragmentManager.java:4)
    at androidx.fragment.app.BackStackRecord.executeOps(BackStackRecord.java:26)
    at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:51)
    at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:10)
    at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:4)
    at androidx.fragment.app.FragmentManager$4.run(FragmentManager.java:1)
    at android.os.Handler.handleCallback(Handler.java:789)
    at android.os.Handler.dispatchMessage(Handler.java:98)
    at android.os.Looper.loop(Looper.java:164)
    at android.app.ActivityThread.main(ActivityThread.java:6944)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)

┆Issue is synchronized with this Jira Task

@Amejia481 Amejia481 added <prompts> Component: feature-prompts 💥 crash labels Aug 26, 2020
@Amejia481 Amejia481 self-assigned this Aug 26, 2020
@Amejia481 Amejia481 added this to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Aug 26, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Aug 26, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Aug 26, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Aug 26, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Aug 26, 2020
@Amejia481 Amejia481 linked a pull request Aug 28, 2020 that will close this issue
4 tasks
bors bot pushed a commit that referenced this issue Aug 28, 2020
8244: Closes #8240: Only dismiss prompts that are not already dismissed r=rocketsroger a=Amejia481




Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
@Amejia481 Amejia481 added the E3 Estimation points: 3 label Aug 28, 2020
@bors bors bot closed this as completed in 0b8c632 Aug 28, 2020
A-C: Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done Aug 28, 2020
@Amejia481 Amejia481 added this to the 58.0.0 🌽 milestone Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 crash E3 Estimation points: 3 <prompts> Component: feature-prompts
Development

Successfully merging a pull request may close this issue.

1 participant