Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

"devtools" extension permission has wrong translation mapping #8267

Closed
Rob--W opened this issue Aug 27, 2020 · 1 comment
Closed

"devtools" extension permission has wrong translation mapping #8267

Rob--W opened this issue Aug 27, 2020 · 1 comment
Labels
<web-extensions>

Comments

@Rob--W
Copy link
Contributor

Rob--W commented Aug 27, 2020 •
edited by data-sync-user
Loading

The "devtools" permission seems to have an incorrect translation name, likely a bad copy & paste.

android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/Addon.kt

Lines 187 to 188 in 1a62765

"topSites" to R.string.mozac_feature_addons_permissions_top_sites_description,
"devtools" to R.string.mozac_feature_addons_permissions_top_sites_description

The "devtools" extension API isn't even supported on Android, so this can be resolved by just removing that line.

┆Issue is synchronized with this Jira Task
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 23, 2020
@Amejia481
Closes issue mozilla-mobile#8267: Devtools permission had wrong trans…
7ba036f 
…lation.
mergify bot pushed a commit that referenced this issue Sep 24, 2020
@Amejia481 @mergify
Closes issue #8267: Devtools permission had wrong translation.
359e646
@Rob--W
Copy link
Contributor Author

Rob--W commented Oct 15, 2020

Fixed by #8476 .

@Rob--W Rob--W closed this as completed Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
<web-extensions>
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Amejia481 @Rob--W