Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call startForegroundService instead of startService on DownloadMiddleware #8363

Closed
Amejia481 opened this issue Sep 9, 2020 · 1 comment
Closed
Assignees
Labels
<download> Component: feature-download E3 Estimation points: 3
Milestone

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Sep 9, 2020

Related issue mozilla-mobile/fenix#14852

For restoring downloads, we are using context.startService(), this could cause issues as the app could be in background. We should be calling ContextCompat.startForegroundService as we are already fulling the foreground contract .

┆Issue is synchronized with this Jira Task

@Amejia481 Amejia481 changed the title startForegroundService instead of normal service on DownloadMiddleware Call startForegroundService instead of startService on DownloadMiddleware Sep 9, 2020
@Amejia481 Amejia481 self-assigned this Sep 9, 2020
@Amejia481 Amejia481 added the <download> Component: feature-download label Sep 9, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 9, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 9, 2020
@Amejia481 Amejia481 added the E3 Estimation points: 3 label Sep 9, 2020
@Amejia481 Amejia481 added this to the 58.0.0 🌽 milestone Sep 9, 2020
@Amejia481 Amejia481 added this to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Sep 9, 2020
bors bot pushed a commit that referenced this issue Sep 9, 2020
8364: Closes issue #8363: Call startForegroundService instead of startService on DownloadMiddleware r=rocketsroger a=Amejia481




Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
bors bot pushed a commit that referenced this issue Sep 9, 2020
8351: For #8350 - Resize download prompt close_button r=Amejia481 a=codrut-topliceanu



8362:  GeckoView update (beta) (20200909-140929) r=pocmo a=MickeyMoz



8364: Closes issue #8363: Call startForegroundService instead of startService on DownloadMiddleware r=rocketsroger a=Amejia481




Co-authored-by: codrut.topliceanu <codrut.topliceanu@softvision.ro>
Co-authored-by: MickeyMoz <sebastian@mozilla.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
pocmo pushed a commit that referenced this issue Sep 10, 2020
@Amejia481
Copy link
Contributor Author

Amejia481 commented Sep 10, 2020

Closed by 464408c

A-C: Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<download> Component: feature-download E3 Estimation points: 3
Development

No branches or pull requests

1 participant