Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Migrate sitePermissions from Observer to Flow #8554

Closed
codrut-topliceanu opened this issue Sep 30, 2020 · 0 comments
Closed

Migrate sitePermissions from Observer to Flow #8554

codrut-topliceanu opened this issue Sep 30, 2020 · 0 comments
Assignees
Labels
<sitepermissions> Component: feature-sitepermissions

Comments

@codrut-topliceanu
Copy link
Contributor

codrut-topliceanu commented Sep 30, 2020

Will fix mozilla-mobile/fenix#14637
At the moment SitePermissionsFeature uses an Observer to check if a permissionRequest for the current session has been called. This does currently does not handle the case where multiple requests are made from embedded elements.
In trying to fix this I suggest moving away from observing Session to using Kotlin Flow with ContentState.

┆Issue is synchronized with this Jira Task

@codrut-topliceanu codrut-topliceanu added the <sitepermissions> Component: feature-sitepermissions label Sep 30, 2020
@codrut-topliceanu codrut-topliceanu self-assigned this Sep 30, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Sep 30, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 5, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 12, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 12, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 12, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 12, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 12, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 12, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 13, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 22, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 22, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 22, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 22, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 22, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 22, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 23, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 26, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 28, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
<sitepermissions> Component: feature-sitepermissions
Projects
None yet
Development

No branches or pull requests

1 participant