Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Migrate sitePermissions from Observer to Flow #8554

Closed
codrut-topliceanu opened this issue Sep 30, 2020 · 0 comments
Closed

Migrate sitePermissions from Observer to Flow #8554

codrut-topliceanu opened this issue Sep 30, 2020 · 0 comments
Assignees
@codrut-topliceanu
Labels
<sitepermissions> Component: feature-sitepermissions

Comments

@codrut-topliceanu
Copy link
Contributor

codrut-topliceanu commented Sep 30, 2020 •
edited by data-sync-user
Loading

Will fix mozilla-mobile/fenix#14637
At the moment SitePermissionsFeature uses an Observer to check if a permissionRequest for the current session has been called. This does currently does not handle the case where multiple requests are made from embedded elements.
In trying to fix this I suggest moving away from observing Session to using Kotlin Flow with ContentState.

┆Issue is synchronized with this Jira Task
@codrut-topliceanu codrut-topliceanu added the <sitepermissions> Component: feature-sitepermissions label Sep 30, 2020
@codrut-topliceanu codrut-topliceanu self-assigned this Sep 30, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Sep 30, 2020
For mozilla-mobile#8554 - Migrate permissionFeature to KotlinFlow
883060a
@codrut-topliceanu codrut-topliceanu mentioned this issue Sep 30, 2020
Merged
4 tasks
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 5, 2020
For mozilla-mobile#8554 - Addressed comments
4fcb991
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 12, 2020
For mozilla-mobile#8554 - Tests implementation
4328326
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 12, 2020
For mozilla-mobile#8554 - Migrate permissionFeature to KotlinFlow
80dbeea
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 12, 2020
For mozilla-mobile#8554 - Addressed comments
7684ba2
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 12, 2020
For mozilla-mobile#8554 - Tests implementation
2371886
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 12, 2020
For mozilla-mobile#8554 - Fix rebase conflicts
c4a6bc8
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 12, 2020
For mozilla-mobile#8554 - Updates to changelog.md
0983829
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 13, 2020
For mozilla-mobile#8554 - Fixes for failing tests
c6d413e
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 22, 2020
For mozilla-mobile#8554 - Migrate permissionFeature to KotlinFlow
fd35520
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 22, 2020
For mozilla-mobile#8554 - Addressed comments
e5ba056
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 22, 2020
For mozilla-mobile#8554 - Tests implementation
63c06f0
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 22, 2020
For mozilla-mobile#8554 - Fix rebase conflicts
0c6f9d2
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 22, 2020
For mozilla-mobile#8554 - Updates to changelog.md
a0fdb66
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 22, 2020
For mozilla-mobile#8554 - Fixes for failing tests
2427389
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 23, 2020
For mozilla-mobile#8554 - Remove static PermissionRequest from dialog
ddf5d72
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 26, 2020
For mozilla-mobile#8554 - Permissions Dialogs now use PermissionReque…
bcbb297 
…stId
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 28, 2020
For mozilla-mobile#8554 - Add doc for new id property
2f92ec2
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Oct 28, 2020
For mozilla-mobile#8554 - Migrate permissionFeature to KotlinFlow
7bee73c
@codrut-topliceanu codrut-topliceanu mentioned this issue Oct 28, 2020
Merged
3 tasks
mergify bot pushed a commit that referenced this issue Oct 28, 2020
@mergify
For #8554 - Migrate permissionFeature to KotlinFlow
1befbad
@codrut-topliceanu codrut-topliceanu mentioned this issue Oct 30, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@codrut-topliceanu codrut-topliceanu

Labels
<sitepermissions> Component: feature-sitepermissions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codrut-topliceanu