Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Add downloaded files manually to the system downloads database when the scoped storage is not used #8585

Closed
Amejia481 opened this issue Oct 1, 2020 · 0 comments
Assignees
Labels
🐞 bug Something isn't working <download> Component: feature-download E5 Estimation points: 5
Milestone

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Oct 1, 2020

The scoped storage api by default adds files to the system database making them available to be seem to other apps, in older version of Android we have add those files manually. The last time when we updated the condition of when the scoped APi is used, we forgot to also update the dependent function that adds manually files to the system downloads database. As a result we are seeing mozilla-mobile/fenix#8754 as a regression.

┆Issue is synchronized with this Jira Task

@Amejia481 Amejia481 self-assigned this Oct 1, 2020
@Amejia481 Amejia481 added the <download> Component: feature-download label Oct 1, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Oct 1, 2020
@Amejia481 Amejia481 added the 🐞 bug Something isn't working label Oct 1, 2020
@Amejia481 Amejia481 added this to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Oct 1, 2020
@Amejia481 Amejia481 added the E5 Estimation points: 5 label Oct 1, 2020
mergify bot pushed a commit that referenced this issue Oct 1, 2020
A-C: Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done Oct 1, 2020
@Amejia481 Amejia481 added this to the 62.0.0 🥮 milestone Oct 2, 2020
st3fan pushed a commit that referenced this issue Oct 5, 2020
bors bot pushed a commit that referenced this issue Oct 5, 2020
8616: Uplift: Closes issue #8585: Fix regression files not been added to the downloads database system r=grigoryk a=st3fan

Uplift for #8585 to the `releases/60.0` branch.

This merged cleanly except for the documentation because this fix was referenced in the change log for 61. I moved that text to the changelog for 60.0.

### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [ ] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [ ] **Changelog**: This PR includes [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md) or does not need one
- [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones) of the version currently in development.
- **Breaking Changes**: If this is a breaking change, please push a draft PR on [Reference Browser](https://github.com/mozilla-mobile/reference-browser) to address the breaking issues.


Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
st3fan pushed a commit that referenced this issue Oct 5, 2020
bors bot pushed a commit that referenced this issue Oct 6, 2020
8616: Uplift: Closes issue #8585: Fix regression files not been added to the downloads database system r=grigoryk a=st3fan

Uplift for #8585 to the `releases/60.0` branch.

This merged cleanly except for the documentation because this fix was referenced in the change log for 61. I moved that text to the changelog for 60.0.

### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [ ] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [ ] **Changelog**: This PR includes [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md) or does not need one
- [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones) of the version currently in development.
- **Breaking Changes**: If this is a breaking change, please push a draft PR on [Reference Browser](https://github.com/mozilla-mobile/reference-browser) to address the breaking issues.


Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Something isn't working <download> Component: feature-download E5 Estimation points: 5
Projects
No open projects
Development

No branches or pull requests

1 participant