Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Add the ability to rename a Top Site #8751

Closed
gabrielluong opened this issue Oct 20, 2020 · 0 comments · Fixed by #8799
Closed

Add the ability to rename a Top Site #8751

gabrielluong opened this issue Oct 20, 2020 · 0 comments · Fixed by #8799
Labels
<top-sites> Component: feature-top-sites
Projects
Top Sites
Milestone
65.0.0 🧅

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Oct 20, 2020 •
edited by data-sync-user

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong added the <top-sites> Component: feature-top-sites label Oct 20, 2020
@gabrielluong gabrielluong self-assigned this Oct 20, 2020
@gabrielluong gabrielluong added this to Backlog in Top Sites Oct 20, 2020
lorenzos added a commit to lorenzos/android-components that referenced this issue Oct 26, 2020
@lorenzos
Issue mozilla-mobile#8751: Added DAO method to update top site entries
afca80f
lorenzos added a commit to lorenzos/android-components that referenced this issue Oct 26, 2020
@lorenzos
Issue mozilla-mobile#8751: Added storage and use-case methods to rena…
0f1c590 
…me top site entries
@lorenzos lorenzos mentioned this issue Oct 26, 2020
Merged
3 tasks
lorenzos added a commit to lorenzos/android-components that referenced this issue Oct 26, 2020
@lorenzos
Issue mozilla-mobile#8751: Updated changelog.md
9c78b00
lorenzos added a commit to lorenzos/android-components that referenced this issue Oct 26, 2020
@lorenzos
Issue mozilla-mobile#8751: Fixed lint check (wildcard imports, blank …
cbe3ff5 
…spaces)
@gabrielluong gabrielluong moved this from Backlog to In Review in Top Sites Oct 27, 2020
@gabrielluong gabrielluong removed their assignment Oct 27, 2020
@mergify mergify bot closed this as completed in #8799 Oct 27, 2020
Top Sites automation moved this from In Review to Done Oct 27, 2020
mergify bot added a commit that referenced this issue Oct 27, 2020
@lorenzos @gabrielluong @mergify
Closes #8751: Added methods to rename top site entries (#8799)
04a4c43 
* Issue #8751: Added DAO method to update top site entries

* Issue #8751: Added storage and use-case methods to rename top site entries

* Issue #8751: Updated changelog.md

* Issue #8751: Fixed lint check (wildcard imports, blank spaces)

* Apply changelog suggestions from code review

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>

* Apply methods ordering suggestions from code review

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@Amejia481 Amejia481 added this to the 65.0.0 milestone Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
<top-sites> Component: feature-top-sites
Projects
No open projects
Top Sites
  
Done
Milestone
65.0.0 🧅
Development

Successfully merging a pull request may close this issue.

Closes #8751: Added methods to rename top site entries lorenzos/android-components
2 participants
@Amejia481 @gabrielluong