Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Add the ability to rename a Top Site #8751

Closed
gabrielluong opened this issue Oct 20, 2020 · 0 comments · Fixed by #8799
Closed

Add the ability to rename a Top Site #8751

gabrielluong opened this issue Oct 20, 2020 · 0 comments · Fixed by #8799
Labels
<top-sites> Component: feature-top-sites
Projects
Milestone

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Oct 20, 2020

┆Issue is synchronized with this Jira Task

@gabrielluong gabrielluong added the <top-sites> Component: feature-top-sites label Oct 20, 2020
@gabrielluong gabrielluong self-assigned this Oct 20, 2020
@gabrielluong gabrielluong added this to Backlog in Top Sites Oct 20, 2020
lorenzos added a commit to lorenzos/android-components that referenced this issue Oct 26, 2020
lorenzos added a commit to lorenzos/android-components that referenced this issue Oct 26, 2020
lorenzos added a commit to lorenzos/android-components that referenced this issue Oct 26, 2020
lorenzos added a commit to lorenzos/android-components that referenced this issue Oct 26, 2020
@gabrielluong gabrielluong moved this from Backlog to In Review in Top Sites Oct 27, 2020
@gabrielluong gabrielluong removed their assignment Oct 27, 2020
@mergify mergify bot closed this as completed in #8799 Oct 27, 2020
Top Sites automation moved this from In Review to Done Oct 27, 2020
mergify bot added a commit that referenced this issue Oct 27, 2020
* Issue #8751: Added DAO method to update top site entries

* Issue #8751: Added storage and use-case methods to rename top site entries

* Issue #8751: Updated changelog.md

* Issue #8751: Fixed lint check (wildcard imports, blank spaces)

* Apply changelog suggestions from code review

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>

* Apply methods ordering suggestions from code review

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@Amejia481 Amejia481 added this to the 65.0.0 milestone Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
<top-sites> Component: feature-top-sites
Projects
No open projects
Top Sites
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants