Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Call stopForeground when all downloads are completed #8857

Closed
Amejia481 opened this issue Oct 30, 2020 · 0 comments
Closed

Call stopForeground when all downloads are completed #8857

Amejia481 opened this issue Oct 30, 2020 · 0 comments
Assignees
Labels
🐞 bug Something isn't working <download> Component: feature-download
Milestone

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Oct 30, 2020

To be able to have background privileges on AbstractFetchDownloadService, we have to adhere to the rules of Foreground services, one of these rule indicates that a foreground service need to have a pinned notification to make users aware of the app doing something in background, while we have these privileges the notification can't be dismissed or swipe away. This what users are experiencing in issues like mozilla-mobile/fenix#15527, this is not a problem while downloads are being downloaded as we don't want users swiping them away by mistake, BUT when downloads are completed we need to call stopForeground and allow users to swipe the foreground notification away.

┆Issue is synchronized with this Jira Task

@Amejia481 Amejia481 added 🐞 bug Something isn't working <download> Component: feature-download labels Oct 30, 2020
@Amejia481 Amejia481 self-assigned this Oct 30, 2020
@Amejia481 Amejia481 changed the title Stop the AbstractFetchDownloadService when all downloads are completed Call stopForeground on when all downloads are completed Oct 30, 2020
@Amejia481 Amejia481 changed the title Call stopForeground on when all downloads are completed Call stopForeground when all downloads are completed Oct 30, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Oct 30, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Nov 3, 2020
@Amejia481 Amejia481 added this to the 64.0.0 🏡 milestone Nov 3, 2020
@mergify mergify bot closed this as completed in 4c7ff86 Nov 3, 2020
A-C: Android Components Sprint Planning automation moved this from ⏳ Review/QA to 🏁 Done Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Something isn't working <download> Component: feature-download
Projects
None yet
Development

No branches or pull requests

1 participant