Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Refactor SwipeRefreshFeature #8943

Closed
Amejia481 opened this issue Nov 11, 2020 · 0 comments
Closed

Refactor SwipeRefreshFeature #8943

Amejia481 opened this issue Nov 11, 2020 · 0 comments
Assignees
@Amejia481
Labels
🐞 bug Something isn't working
Milestone
67.0.0 📚

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Nov 11, 2020 •
edited by data-sync-user

We have some issues caused by SwipeRefreshFeature using EngineSession.Observer
by default EngineSession.Observer rejects onAppPermissionRequest and onContentPermissionRequest
, as a side effect of it we have related site permissions issues like mozilla-mobile/fenix#8987 and mozilla-mobile/fenix#16411, moreover eventually we want to removeEngineSession.Observer, for the reasons mentioned above is a good a idea to refactor SwipeRefreshFeature to not use EngineSession.Observer instead use the BrowserStore.

┆Issue is synchronized with this Jira Task
@Amejia481 Amejia481 added the 🐞 bug Something isn't working label Nov 11, 2020
@Amejia481 Amejia481 self-assigned this Nov 11, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Nov 11, 2020
@Amejia481
Closes mozilla-mobile#8943 refactor SwipeRefreshFeature to not use
d0f2ac6 
EngineSession.Observer
Amejia481 added a commit to Amejia481/android-components that referenced this issue Nov 11, 2020
@Amejia481
Closes mozilla-mobile#8943 refactor SwipeRefreshFeature to not use En…
ecc8e50 
…gineSession.Observer
@Amejia481 Amejia481 added this to the 66.0.0 milestone Nov 11, 2020
@jonalmeida jonalmeida modified the milestones: 66.0.0, 67.0.0 Nov 12, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Nov 12, 2020
@Amejia481
Closes mozilla-mobile#8943 refactor SwipeRefreshFeature to not use En…
9a510e8 
…gineSession.Observer
@mergify mergify bot closed this as completed in e7100fe Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Amejia481 Amejia481

Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
67.0.0 📚
Development

No branches or pull requests
2 participants
@Amejia481 @jonalmeida