Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Selected prompt choice is not visible on initial view #8953

Closed
jonalmeida opened this issue Nov 11, 2020 · 0 comments · Fixed by #8954
Closed

Selected prompt choice is not visible on initial view #8953

jonalmeida opened this issue Nov 11, 2020 · 0 comments · Fixed by #8954
Assignees
@jonalmeida
Labels
🌟 feature New functionality and improvements <prompts> Component: feature-prompts
Projects
A-C: Android Components Sprint Planning
Milestone
67.0.0 📚

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Nov 11, 2020 •
edited by data-sync-user

When we show a list of choice prompts from web content that has a selected item, we should always scroll to that first when we load the list.

For example, you can see the issue currently by clicking the js multiple choice prompt: https://jsfiddle.net/mdv10se9/1/

Fenix issue: mozilla-mobile/fenix#14870

┆Issue is synchronized with this Jira Task
@jonalmeida jonalmeida added 🌟 feature New functionality and improvements <prompts> Component: feature-prompts labels Nov 11, 2020
@jonalmeida jonalmeida self-assigned this Nov 11, 2020
jonalmeida added a commit to jonalmeida/android-components that referenced this issue Nov 11, 2020
@jonalmeida
Close mozilla-mobile#8953: Scroll to the selected choice prompt if on…
fa1624e 
…e exists
@jonalmeida jonalmeida mentioned this issue Nov 11, 2020
Merged
4 tasks
jonalmeida added a commit to jonalmeida/android-components that referenced this issue Nov 16, 2020
@jonalmeida
Close mozilla-mobile#8953: Scroll to the selected choice prompt if on…
c617fe7 
…e exists
jonalmeida added a commit to jonalmeida/android-components that referenced this issue Nov 16, 2020
@jonalmeida
Close mozilla-mobile#8953: Scroll to the selected choice prompt if on…
cf67fe8 
…e exists
@mergify mergify bot closed this as completed in #8954 Nov 16, 2020
A-C: Android Components Sprint Planning automation moved this from ⏳ Review/QA to 🏁 Done Nov 16, 2020
mergify bot pushed a commit that referenced this issue Nov 16, 2020
@jonalmeida @mergify
Close #8953: Scroll to the selected choice prompt if one exists
cdb9256
@jonalmeida jonalmeida added this to the 67.0.0 📚 milestone Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonalmeida jonalmeida

Labels
🌟 feature New functionality and improvements <prompts> Component: feature-prompts
Projects
No open projects
A-C: Android Components Sprint Planning
  
🏁 Done
Milestone
67.0.0 📚
Development

Successfully merging a pull request may close this issue.

Close #8953: Scroll to the selected choice prompt if one exists jonalmeida/android-components
1 participant
@jonalmeida