Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Sanitize download content type #9553

Closed
Amejia481 opened this issue Jan 29, 2021 · 0 comments
Closed

Sanitize download content type #9553

Amejia481 opened this issue Jan 29, 2021 · 0 comments
Assignees
Labels
🐞 bug Something isn't working <download> Component: feature-download
Milestone

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Jan 29, 2021

When we moved to the new GV download api, we inherited more responsibility related to parsing metadata related to a download request, some sites pass clutter information to the CONTENT_TYPE for example application/pdf; qs=0.001, for that reason we need to sanitize this data. As result when when we try to open a file we were using this clutter content type causing multiple files to not open after being downloaded Related issue mozilla-mobile/fenix#17502 mozilla-mobile/fenix#17099

┆Issue is synchronized with this Jira Task

@Amejia481 Amejia481 added 🐞 bug Something isn't working <download> Component: feature-download labels Jan 29, 2021
@Amejia481 Amejia481 self-assigned this Jan 29, 2021
@Amejia481 Amejia481 added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Jan 29, 2021
@Amejia481 Amejia481 changed the title Sanitize mime type Sanitize downlaod content type Jan 29, 2021
@Amejia481 Amejia481 changed the title Sanitize downlaod content type Sanitize download content type Jan 29, 2021
Amejia481 added a commit to Amejia481/android-components that referenced this issue Jan 29, 2021
@Amejia481 Amejia481 moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Jan 29, 2021
@Amejia481 Amejia481 moved this from In Development (WIP limit - 15) to Review in progress (WIP limit -11) in Android Engineering Team Kanban board Feb 1, 2021
@mergify mergify bot closed this as completed in 37d1148 Feb 1, 2021
Android Engineering Team Kanban board automation moved this from Review in progress (WIP limit -11) to Done Feb 1, 2021
@gabrielluong gabrielluong added this to the 73.0.0 milestone Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Something isn't working <download> Component: feature-download
Projects
No open projects
Development

No branches or pull requests

2 participants