Wire up the history tracking delegate for GeckoView

[linacambridge]

I tested this with my local GeckoView build, the sample browser, and @grigoryk's in-memory history storage, and it works! 🎉 There's also a commit that points the Nightly x86 target to m-c instead, for folks to try out if they'd like. 😄

[pocmo]

Woo! Awesome. :)

If this is in mozilla-central already... will updating nightly_version be enough to get that landed (not sure if there are other breaking API changes since the last update)? :)

[pocmo]

GV bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1494713

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@2475162). Click here to learn what that means.
The diff coverage is 61.53%.

@@            Coverage Diff            @@
##             master    #1238   +/-   ##
=========================================
  Coverage          ?   82.46%           
  Complexity        ?     1632           
=========================================
  Files             ?      197           
  Lines             ?     6508           
  Branches          ?     1123           
=========================================
  Hits              ?     5367           
  Misses            ?      637           
  Partials          ?      504

Impacted Files	Coverage Δ	Complexity Δ
...mponents/feature/storage/HistoryTrackingFeature.kt	90% <ø> (ø)	1 <0> (?)
...mponents/browser/engine/system/SystemEngineView.kt	78.53% <0%> (ø)	31 <0> (?)
...nents/browser/storage/sync/PlacesHistoryStorage.kt	82.85% <0%> (ø)	12 <0> (?)
...s/browser/storage/memory/InMemoryHistoryStorage.kt	88.88% <88.88%> (ø)	27 <5> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2475162...ff39a88. Read the comment docs.

[linacambridge]

@mozilla-mobile/act This is ready for re-review, now that the GV API has landed! Please take a look at how I'm using scope.launch in particular, as I'm not sure that I'm doing it right.

From talking to @grigoryk today, it sounds like this is fine for now, but we'll want to agree on a story for scopes eventually (#1347). @thomcc might have insights here, too.

[grigoryk]

As noted before, we're likely going to change the scoping story, but that's fine for now. This can land with a few changes.

For bonus points, I think you should be able to add tests for this. See GeckoEngineSessionTest

[linacambridge]

@grigoryk Whew! I think this is ready for re-review. Changes since last time:

• Removed the privateMode argument from HistoryTrackingDelegate. Instead, we'll skip the call to the delegate entirely.
• Bail early instead of launching a coroutine if a delegate isn't set.
• Tests actually work! 🎉
• Made both overloads of getVisited suspend functions.

[linacambridge]

Looks like the browser-awesomebar failure is #1300; I didn't see it fail on previous runs.

[grigoryk]

A few small nits, but this look good to me! Thanks!

[grigoryk]

This landed!