Issue #2530: Add Autopush support components #2694
Conversation
|
Some comments from @grigoryk after an offline conversation:
For AbstractFirebasePushService:
|
Codecov Report
@@ Coverage Diff @@
## master #2694 +/- ##
=========================================
Coverage ? 81.41%
Complexity ? 3079
=========================================
Files ? 398
Lines ? 13546
Branches ? 1923
=========================================
Hits ? 11029
Misses ? 1721
Partials ? 796
Continue to review full report at Codecov.
|
c6bb03f
to
70d7075
2650023
to
a4ed8e7
|
(first pass) |
...cept/push/src/main/java/mozilla/components/concept/push/PushProcessor.kt
Outdated
Show resolved
Hide resolved
...onents/concept/push/src/main/java/mozilla/components/concept/push/Bus.kt
Show resolved
Hide resolved
...cept/push/src/main/java/mozilla/components/concept/push/PushProcessor.kt
Outdated
Show resolved
Hide resolved
...re/push/src/main/java/mozilla/components/feature/push/AutoPushFeature.kt
Outdated
Show resolved
Hide resolved
...re/push/src/main/java/mozilla/components/feature/push/AutoPushFeature.kt
Show resolved
Hide resolved
...cept/push/src/main/java/mozilla/components/concept/push/PushProcessor.kt
Show resolved
Hide resolved
...re/push/src/main/java/mozilla/components/feature/push/AutoPushFeature.kt
Show resolved
Hide resolved
...re/push/src/main/java/mozilla/components/feature/push/AutoPushFeature.kt
Show resolved
Hide resolved
|
I think we can kill some complexity and abstraction layers here pretty easily. Specifically, the bus and the RustPushConnection class. It's fine if you'd want to do this in a follow-up, just make sure to file issues and outline the cleanup work in comments. |
...feature/push/src/main/java/mozilla/components/feature/push/Connection.kt
Show resolved
Hide resolved
...feature/push/src/main/java/mozilla/components/feature/push/Connection.kt
Outdated
Show resolved
Hide resolved
...java/mozilla/components/lib/push/firebase/AbstractFirebasePushService.kt
Show resolved
Hide resolved
...java/mozilla/components/lib/push/firebase/AbstractFirebasePushService.kt
Show resolved
Hide resolved
...java/mozilla/components/lib/push/firebase/AbstractFirebasePushService.kt
Outdated
Show resolved
Hide resolved
...feature/push/src/main/java/mozilla/components/feature/push/Connection.kt
Show resolved
Hide resolved
...feature/push/src/main/java/mozilla/components/feature/push/Connection.kt
Show resolved
Hide resolved
...feature/push/src/main/java/mozilla/components/feature/push/Connection.kt
Show resolved
Hide resolved
...feature/push/src/main/java/mozilla/components/feature/push/Connection.kt
Show resolved
Hide resolved
...feature/push/src/main/java/mozilla/components/feature/push/Connection.kt
Show resolved
Hide resolved
|
You've certainly thought enough about this - let's land it, and iterate in the tree. Great work!! |
...cept/push/src/main/java/mozilla/components/concept/push/PushProcessor.kt
Show resolved
Hide resolved
...feature/push/src/main/java/mozilla/components/feature/push/MessageBus.kt
Show resolved
Hide resolved
00db80d
to
3f93b4b
ca6dfbe
into
mozilla-mobile:master
Pull Request checklist