Join GitHub today
Sync access token caching, API simplification #3579
I've started pulling on one little thread, and ended up with a few more changes than initially anticipated.
Raison d'être for this PR - introducing access token caching for Sync.
And this is where the "thread pulling" begins! In order to "own" the access token for sync, account manager needs to be aware of the "sync scope".
Application is now expected to interact with sync only via AccountManager's
Above changes were a good reason to move support classes from feature-sync and into services-firefox-account. Note that since "sync" is part of our "storage" modules, this change doesn't mean that you need to take an extra native dependency on your classpath simply if you need to use FxA. Thanks to concept-sync, actual "Firefox Sync" machinery (within libplaces) is still fully decoupled from FxA.
Since we're churning the public API anyway, I took the chance to introduce a few more simplifications at the API layer:
Documentation of public APIs and classes was improved.
Pull Request checklist
3 times, most recently
Jul 2, 2019
csadilek left a comment
Only had a few nits. I think this is simpler now and the public API looks much better.
One concern is that this is a big change for the upcoming point release, but at the same time seems low risk and it's fixing a critical bug. Let's chat about this part more. There's also #3631 to consider...