Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set 'wasMigrated' to false in the Glean SDK #4511

Merged
merged 1 commit into from Sep 24, 2019

Conversation

@Dexterp37
Copy link
Contributor

commented Sep 24, 2019

This is only useful as a safety measure in case the data migration plan goes wrong and we're forced to downgrade the version Glean SDK consumers are using from glean-core to glean-ac. In that case, this code will run and will reset the status of the migration. When attempting the upgrade again, glean-core will perform the migration one more time.


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.
This is only useful as a safety measure in case the data migration plan goes
wrong and we're forced to downgrade the version Glean SDK consumers are using
from glean-core to glean-ac. In that case, this code will run and will reset
the status of the migration. When attempting the upgrade again, glean-core
will perform the migration one more time.
@Dexterp37 Dexterp37 requested review from badboy and mdboom Sep 24, 2019
@Dexterp37 Dexterp37 requested a review from mozilla-mobile/telemetry as a code owner Sep 24, 2019
@Dexterp37

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2019

This is a complement to mozilla/glean#309

@badboy
badboy approved these changes Sep 24, 2019
@Dexterp37

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2019

bors r+

bors bot pushed a commit that referenced this pull request Sep 24, 2019
Merge #4511
4511: Always set 'wasMigrated' to false in the Glean SDK r=Dexterp37 a=Dexterp37

This is only useful as a safety measure in case the data migration plan goes wrong and we're forced to downgrade the version Glean SDK consumers are using from glean-core to glean-ac. In that case, this code will run and will reset the status of the migration. When attempting the upgrade again, glean-core will perform the migration one more time.




Co-authored-by: Alessio Placitelli <alessio.placitelli@gmail.com>
@bors

This comment has been minimized.

Copy link

commented Sep 24, 2019

Build succeeded

@bors bors bot merged commit 51bbe43 into mozilla-mobile:master Sep 24, 2019
2 checks passed
2 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
bors Build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.