Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #576: Fretboard: Log ExperimentDownloadException #582

Conversation

@fercarcedo
Copy link
Contributor

@fercarcedo fercarcedo commented Aug 10, 2018

Closes #576

@fercarcedo
Copy link
Contributor Author

@fercarcedo fercarcedo commented Aug 10, 2018

If I understood everything correctly, then the client app must call Log.addSink in order to make the logs visible, because otherwise they don't get shown on logcat. Is that correct?

@codecov
Copy link

@codecov codecov bot commented Aug 10, 2018

Codecov Report

No coverage uploaded for pull request base (master@8a344b7). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #582   +/-   ##
=========================================
  Coverage          ?   77.42%           
  Complexity        ?      967           
=========================================
  Files             ?      147           
  Lines             ?     3571           
  Branches          ?      493           
=========================================
  Hits              ?     2765           
  Misses            ?      557           
  Partials          ?      249
Impacted Files Coverage Δ Complexity Δ
.../mozilla/components/service/fretboard/Fretboard.kt 100% <100%> (ø) 16 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a344b7...9875715. Read the comment docs.

@pocmo pocmo merged commit 42bcfbc into mozilla-mobile:master Aug 10, 2018
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants