This repository was archived by the owner on Nov 1, 2022. It is now read-only.
Closes #6314: Support fetching / downloading data URIs #6475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6475 +/- ##
============================================
- Coverage 78.52% 78.38% -0.14%
+ Complexity 4687 4678 -9
============================================
Files 621 615 -6
Lines 22610 22519 -91
Branches 3309 3297 -12
============================================
- Hits 17754 17652 -102
- Misses 3496 3512 +16
+ Partials 1360 1355 -5
Continue to review full report at Codecov.
|
pocmo
approved these changes
Apr 2, 2020
| * @return The generated [Response] including the decoded bytes as body. | ||
| */ | ||
| @Suppress("TooGenericExceptionCaught") | ||
| fun fetchDataUri(request: Request): Response { |
There was a problem hiding this comment.
Should we put this into Client and make it protected (like defaultHeaders) so that it is not used outside of a Client implementation? This could now end up getting called by app code.
There was a problem hiding this comment.
OK, makes sense. Updated!
| @Test | ||
| override fun getDataUri() { | ||
| // We can't run this test case because Base64 encoding is not available but we can verify | ||
| // that we attempt to fetch the data URI. |
There was a problem hiding this comment.
If we run this with AndroidJUnit4 then we should be able to use the Base64 classes, I think?
There was a problem hiding this comment.
Ah yes, good catch! I've upgraded the lib and removed the test override as the base test is running fine now!
| val headers = MutableHeaders( | ||
| CONTENT_TYPE_HEADER to contentType, | ||
| CONTENT_LENGTH_HEADER to bytes.size.toString() | ||
| ) |
There was a problem hiding this comment.
OK, added another test case and made this more robust too.
|
bors r=Amejia481,pocmo |
bors bot
pushed a commit
that referenced
this pull request
Apr 2, 2020
6475: Closes #6314: Support fetching / downloading data URIs r=Amejia481,pocmo a=csadilek With this we can fetch from data URIs and downloads "just work" (we don't require any special handling). So, e.g. this works now (which is also used by uBlock to save backups): ```html <a href="data:text/plain;base64,SGVsbG8sIFdvcmxkIQ==" download="backup.txt">Backup</a> ``` https://github.com/gorhill/uBlock/blob/08d370d32e648c2823e1bc31fcd9f7e1f96d155a/platform/chromium/vapi-common.js#L172 GV didn't want to add API for it so I took a stab at adding this to our fetch libs: #6314 (comment) @pocmo can you take a look since we looked at download stuff today :). I've time-boxed this and limited to base64 encoded URIs. The device and unit tests pass and the download works / can be tested here: https://jsfiddle.net/nue9rg0L/2/ Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Timed out |
|
bors retry |
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we can fetch from data URIs and downloads "just work" (we don't require any special handling). So, e.g. this works now (which is also used by uBlock to save backups):
https://github.com/gorhill/uBlock/blob/08d370d32e648c2823e1bc31fcd9f7e1f96d155a/platform/chromium/vapi-common.js#L172
GV didn't want to add API for it so I took a stab at adding this to our fetch libs: #6314 (comment)
@pocmo can you take a look since we looked at download stuff today :). I've time-boxed this and limited to base64 encoded URIs. The device and unit tests pass and the download works / can be tested here:
https://jsfiddle.net/nue9rg0L/2/