For #6564 - Only display URL hostname for tabstray

[darkwing]

Fixes #6564. We don't want the entire URL, just the hostname, per @topotropic's direction.

---

Pull Request checklist

• Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry or does not need one
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

• Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
• Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

[codecov]

Codecov Report

Merging #6566 into master will not change coverage by %.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #6566   +/-   ##
=========================================
  Coverage     77.62%   77.62%           
  Complexity     4718     4718           
=========================================
  Files           627      627           
  Lines         22959    22959           
  Branches       3384     3384           
=========================================
  Hits          17823    17823           
  Misses         3746     3746           
  Partials       1390     1390           

Impacted Files	Coverage Δ	Complexity Δ
...zilla/components/browser/tabstray/TabViewHolder.kt	93.10% <0.00%> (ø)	5.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f4dba9...0bd7546. Read the comment docs.

[jonalmeida]

Nice, almost there! We should add tests to add coverage around that try-catch block.

We have a very short guide to generating a coverage report for the component you're working on to see where test coverage is lacking.

You should also have a look at setting up detekt and ktlint, which is used for most of our Android projects, so that it's run before pushing a patch up to CI. This will save personal time and CPU time to do it as a pre-push hook.

[jonalmeida]

Let's use the catch clause properly to set the fallback URL if the parsing fails.

Suggested change

	var url = tab.url
	try {
	url = URL(tab.url).host
	}
	catch (e: MalformedURLException) { /* ignore error */ }
	urlView?.text = url
	try {
	val tabHost = URL(tab.url).host
	urlView?.text = tabHost
	} catch (e: MalformedURLException) {
	urlView?.text = tab.url
	}

It's generally not good practice to not handle the exceptions. If this is not the place you want to handle it, you can annotate the as a method that throws exceptions and the caller will then have to put the try-catch clause appropriately

[csadilek]

nit: we should lift the assignment out of the try catch e.g:

urlView?.text = try {
    URL(tab.url).host          
} catch (e: MalformedURLException) {
    tab.url
}

[csadilek]

We also have an extension function for this we could re-use here:

android-components/components/support/ktx/src/main/java/mozilla/components/support/ktx/kotlin/String.kt

Line 107 in f362c94

fun String.tryGetHostFromUrl(): String = try {

So, you can just call:

urlView?.text = tab.url.tryGetHostFromUrl()

[jonalmeida]

We also need to add a changelog entry. :)

[jonalmeida]

This looks great, thanks @darkwing !

bors r+

[bors]

Build failed

• complete-push

[jonalmeida]

bors retry

[bors]

Build succeeded

• complete-push