Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Conversation

@NotWoods
Copy link
Contributor

Broken out from the main menu2 PR. Adds a new concept menu type and corresponding view holder.


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@NotWoods NotWoods mentioned this pull request Jun 23, 2020
6 tasks
@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #7467 into master will decrease coverage by 0.00%.
The diff coverage is 38.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7467      +/-   ##
============================================
- Coverage     77.58%   77.58%   -0.01%     
+ Complexity     5127     4999     -128     
============================================
  Files           688      683       -5     
  Lines         24841    24551     -290     
  Branches       3667     3608      -59     
============================================
- Hits          19274    19047     -227     
+ Misses         4057     4037      -20     
+ Partials       1510     1467      -43     
Impacted Files Coverage Δ Complexity Δ
...lla/components/browser/menu/ext/BrowserMenuItem.kt 66.66% <0.00%> (-6.07%) 0.00 <0.00> (ø)
...onents/browser/menu2/adapter/LastItemViewHolder.kt 80.00% <0.00%> (-20.00%) 2.00 <0.00> (ø)
.../browser/menu2/adapter/MenuCandidateListAdapter.kt 29.72% <0.00%> (-3.61%) 7.00 <0.00> (ø)
...ser/menu2/adapter/NestedMenuCandidateViewHolder.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../components/browser/menu/item/BackPressMenuItem.kt 100.00% <100.00%> (ø) 5.00 <1.00> (+1.00)
.../browser/menu/item/BrowserMenuHighlightableItem.kt 91.48% <100.00%> (ø) 20.00 <3.00> (ø)
...mponents/browser/menu/item/BrowserMenuImageText.kt 100.00% <100.00%> (ø) 9.00 <3.00> (ø)
...ponents/browser/menu/item/ParentBrowserMenuItem.kt 95.00% <100.00%> (-2.37%) 13.00 <1.00> (-1.00)
...components/support/sync/telemetry/SyncTelemetry.kt 85.71% <0.00%> (-1.39%) 41.00% <0.00%> (ø%)
...onents/lib/crash/notification/CrashNotification.kt 94.11% <0.00%> (-0.17%) 2.00% <0.00%> (ø%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 552b63f...8357fe9. Read the comment docs.

Copy link
Contributor

@psymoon psymoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@NotWoods NotWoods force-pushed the nested-menu-concept branch from fed68fd to 8357fe9 Compare June 23, 2020 21:35
@NotWoods
Copy link
Contributor Author

bors r=psymoon

@bors
Copy link

bors bot commented Jun 23, 2020

Build succeeded:

@bors bors bot merged commit 40d123b into mozilla-mobile:master Jun 23, 2020
@NotWoods NotWoods deleted the nested-menu-concept branch June 23, 2020 22:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants