This repository was archived by the owner on Nov 1, 2022. It is now read-only.
TabsUseCases: Open new tabs with "about:blank" by default. #8975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csadilek
approved these changes
Nov 13, 2020
csadilek
reviewed
Nov 13, 2020
| WindowRequest.Type.OPEN -> consumeWindowRequest(state.id) { | ||
| if (state.content.private) { | ||
| tabsUseCases.addPrivateTab( | ||
| url = windowRequest.url, |
Contributor
There was a problem hiding this comment.
Only consequence of this is that we'll see an initial "about:blank" load for new windows (target="_blank" links and window.open).
We have a workaround for this in GeckoEngineSession: https://github.com/mozilla-mobile/android-components/blob/master/components/browser/engine-gecko-nightly/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngineSession.kt#L436-L441 but it won't apply here.
Since this behaved the same in Fennec though we decided it's fine to land this.
pocmo
added
🛬 needs landing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.