From 909ee734bfd9b1b20106d479db3ffddc1c2e3f0f Mon Sep 17 00:00:00 2001 From: Michael Comella Date: Thu, 16 Apr 2020 16:15:35 -0700 Subject: [PATCH] For #8803 - post: update metrics & pings data review URL. --- app/metrics.yaml | 6 +++--- app/pings.yaml | 2 +- docs/metrics.md | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/metrics.yaml b/app/metrics.yaml index 0229c384f922..d69a9a9037a2 100644 --- a/app/metrics.yaml +++ b/app/metrics.yaml @@ -2003,7 +2003,7 @@ startup.timeline: bugs: - https://github.com/mozilla-mobile/fenix/issues/8803 data_reviews: - - https://github.com/mozilla-mobile/fenix/pull/9788#issuecomment-610648980 + - https://github.com/mozilla-mobile/fenix/pull/9788#pullrequestreview-394228626 notification_emails: - perf-android-fe@mozilla.com - mcomella@mozilla.com @@ -2018,7 +2018,7 @@ startup.timeline: bugs: - https://github.com/mozilla-mobile/fenix/issues/8803 data_reviews: - - https://github.com/mozilla-mobile/fenix/pull/9788#issuecomment-610648980 + - https://github.com/mozilla-mobile/fenix/pull/9788#pullrequestreview-394228626 notification_emails: - perf-android-fe@mozilla.com - mcomella@mozilla.com @@ -2033,7 +2033,7 @@ startup.timeline: bugs: - https://github.com/mozilla-mobile/fenix/issues/8803 data_reviews: - - https://github.com/mozilla-mobile/fenix/pull/9788#issuecomment-610648980 + - https://github.com/mozilla-mobile/fenix/pull/9788#pullrequestreview-394228626 notification_emails: - perf-android-fe@mozilla.com - mcomella@mozilla.com diff --git a/app/pings.yaml b/app/pings.yaml index 7633e6ab5c39..c31555476827 100644 --- a/app/pings.yaml +++ b/app/pings.yaml @@ -41,7 +41,7 @@ startup-timeline: bugs: - https://github.com/mozilla-mobile/fenix/issues/8803 data_reviews: - - https://github.com/mozilla-mobile/fenix/pull/9788#issuecomment-610648980 + - https://github.com/mozilla-mobile/fenix/pull/9788#pullrequestreview-394228626 notification_emails: - perf-android-fe@mozilla.com - esmyth@mozilla.com diff --git a/docs/metrics.md b/docs/metrics.md index 06a39b4c6f29..e95729c3ad3b 100644 --- a/docs/metrics.md +++ b/docs/metrics.md @@ -253,9 +253,9 @@ The following metrics are added to the ping: | Name | Type | Description | Data reviews | Extras | Expiration | | --- | --- | --- | --- | --- | --- | -| startup.timeline.clock_ticks_per_second |[counter](https://mozilla.github.io/glean/book/user/metrics/counter.html) |The number of clock tick time units that occur in one second on this particular device. This value is expected to be used in conjunction with the `framework_start` metric. |[1](https://github.com/mozilla-mobile/fenix/pull/9788#issuecomment-610648980)||2020-07-15 | -| startup.timeline.framework_start |[timespan](https://mozilla.github.io/glean/book/user/metrics/timespan.html) |The duration the Android framework takes to start before letting us run code in `*Application.init`. This is calculated from `appInitTimestamp - processStartTimestamp`. `processStartTimestamp` is derived from the clock tick time unit, which is expected to be less granular than nanoseconds. Therefore, we convert and round our timestamps to clock ticks before computing the difference and convert back to nanoseconds to report. For debugging purposes, `clock_ticks_per_second`, which may vary between devices, is also reported as a metric. |[1](https://github.com/mozilla-mobile/fenix/pull/9788#issuecomment-610648980)||2020-07-15 | -| startup.timeline.framework_start_error |[boolean](https://mozilla.github.io/glean/book/user/metrics/boolean.html) |An error when attempting to record `framework_start` - the application init timestamp returned a negative value - which is likely indicative of a bug in the implementation. |[1](https://github.com/mozilla-mobile/fenix/pull/9788#issuecomment-610648980)||2020-07-15 | +| startup.timeline.clock_ticks_per_second |[counter](https://mozilla.github.io/glean/book/user/metrics/counter.html) |The number of clock tick time units that occur in one second on this particular device. This value is expected to be used in conjunction with the `framework_start` metric. |[1](https://github.com/mozilla-mobile/fenix/pull/9788#pullrequestreview-394228626)||2020-07-15 | +| startup.timeline.framework_start |[timespan](https://mozilla.github.io/glean/book/user/metrics/timespan.html) |The duration the Android framework takes to start before letting us run code in `*Application.init`. This is calculated from `appInitTimestamp - processStartTimestamp`. `processStartTimestamp` is derived from the clock tick time unit, which is expected to be less granular than nanoseconds. Therefore, we convert and round our timestamps to clock ticks before computing the difference and convert back to nanoseconds to report. For debugging purposes, `clock_ticks_per_second`, which may vary between devices, is also reported as a metric. |[1](https://github.com/mozilla-mobile/fenix/pull/9788#pullrequestreview-394228626)||2020-07-15 | +| startup.timeline.framework_start_error |[boolean](https://mozilla.github.io/glean/book/user/metrics/boolean.html) |An error when attempting to record `framework_start` - the application init timestamp returned a negative value - which is likely indicative of a bug in the implementation. |[1](https://github.com/mozilla-mobile/fenix/pull/9788#pullrequestreview-394228626)||2020-07-15 |