Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Twitter's bottom bar doesn't look properly when Firefox URL bar is on top #10043

Closed
ghost opened this issue Apr 18, 2020 · 12 comments
Closed
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Toolbar Address bar, see also Feature:Search wontfix

Comments

@ghost
Copy link

ghost commented Apr 18, 2020

Steps to reproduce

Browser version: Firefox Preview v4.3.0

I have the URL bar on top of the interface and when I'm browsing twitter I see what's on pic1, css seems broken. If I use the URL bar on bottom, no problem (pic2). I thought that twitter had css broken, but in fennec this doesn't happen (pic3).

pic1
pic2
pic3
version

Expected behavior

Twitter's bottom bar has to be in the bottom.

Actual behavior

Twitter's bottom bar doesn't look properly.

Device information

  • Android device: Motorola Moto G4 with "/e/" rom
  • Fenix version: 4.3.0

┆Issue is synchronized with this Jira Task

@ghost ghost added the 🐞 bug Crashes, Something isn't working, .. label Apr 18, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 18, 2020
@haltbarmilch
Copy link

haltbarmilch commented Apr 19, 2020

Same problem on Instagram and various other sites.

@LaurentiuApahideanSV
Copy link

LaurentiuApahideanSV commented May 5, 2020

I am able to reproduce the issue on Firefox Preview 4.3.0 but not on Firefox Preview Nightly 200505.
@javipereira Could you download the latest Firefox Preview Nightly from the Google Play store and see if the issue still occurs?

@LaurentiuApahideanSV LaurentiuApahideanSV removed the needs:triage Issue needs triage label May 5, 2020
@ghost
Copy link
Author

ghost commented May 10, 2020

I try now and tell you something 😊

@ghost
Copy link
Author

ghost commented May 10, 2020

Hi!!

I tried with 5.0.0 beta and Nightly 200510 and it works correctly. However, it "jumps" a little bit. I tried with fennec and this does not happen.

Fenix's jumps gif:
fenix

Same test with Fennec:
fennec

Regards,
Javi.

@ekager
Copy link
Contributor

ekager commented May 16, 2020

@sblatz is there an issue for the jumpy bottom content to link to? I couldn't find one with a quick search

@sblatz
Copy link
Contributor

sblatz commented May 18, 2020

@ekager I'm not aware of an issue filed for that. Unfortunately I'm not sure how much we can improve this from the Fenix side. The reason this is happening is because we're calling setVerticalClipping while the toolbar animates. Lots of those calls means it feels "jumpy" 😕 since we can never perfectly track it to the dragging of the toolbar

@yoasif
Copy link
Contributor

yoasif commented May 18, 2020

@sblatz I didn't bother trying this in Fennec because others have done that, but Kiwi seems to work just fine in my testing - no jumpiness. Are you saying that this is more of an AC issue - because I don't think it is a site issue (other browsers work okay).

@sblatz
Copy link
Contributor

sblatz commented May 18, 2020

It is a GeckoView issue, @yoasif. This is "expected" due to our GV implementation of handling scrolling the toolbar.

Adding @snorp in case he wants to chime in here / has a different view!

@yoasif
Copy link
Contributor

yoasif commented May 18, 2020

I don't think that jumpiness can really be "expected"; it feels like a GV bug to me based on your explanation. Just wanted to point out that there doesn't seem to be anything intrinsic about the page that seems to cause this issue.

Sorry if my comment is not very helpful. 😞

@data-sync-user data-sync-user changed the title [Bug] Twitter's bottom bar doesn't look properly when Firefox URL bar is on top FNX3-13606 ⁃ [Bug] Twitter's bottom bar doesn't look properly when Firefox URL bar is on top Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13606 ⁃ [Bug] Twitter's bottom bar doesn't look properly when Firefox URL bar is on top FNX-3248 ⁃ [Bug] Twitter's bottom bar doesn't look properly when Firefox URL bar is on top Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-3248 ⁃ [Bug] Twitter's bottom bar doesn't look properly when Firefox URL bar is on top FNX2-13053 ⁃ [Bug] Twitter's bottom bar doesn't look properly when Firefox URL bar is on top Aug 11, 2020
@cosarara
Copy link

cosarara commented Aug 24, 2020

It is a GeckoView issue, @yoasif. This is "expected" due to our GV implementation of handling scrolling the toolbar.

Adding @snorp in case he wants to chime in here / has a different view!

Is there an open bug report on GV tracking this, then?

@kbrosnan kbrosnan changed the title FNX2-13053 ⁃ [Bug] Twitter's bottom bar doesn't look properly when Firefox URL bar is on top [Bug] Twitter's bottom bar doesn't look properly when Firefox URL bar is on top Aug 27, 2020
@swiesend
Copy link

swiesend commented Sep 3, 2020

I don't think this is expected behaviour, as there are also buttons disappearing.

@Mugurell Mugurell added this to Needs Investigations in Toolbar/Refresh issues via automation Feb 3, 2021
@stale
Copy link

stale bot commented Mar 2, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 2, 2021
@stale stale bot closed this as completed Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Toolbar Address bar, see also Feature:Search wontfix
Projects
Toolbar/Refresh issues
Needs Investigations
Development

No branches or pull requests

7 participants