Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application name in strings should be parameterized #1181

Closed
st3fan opened this Issue Mar 25, 2019 · 2 comments

Comments

3 participants
@st3fan
Copy link
Contributor

st3fan commented Mar 25, 2019

Wherever we mention Fenix in strings, we have to use a parameter so that we can customize the product name on a per-channel basis.

@mheubusch

This comment has been minimized.

Copy link
Collaborator

mheubusch commented Mar 26, 2019

Thanks, @sarentz plus @boek have updated the Fenix strings.xml file (sent to Jeff B via email) - In the app_name string I replaced Fenix with GeckoView Preview and in other strings that hard-coded the name I changed Fenix to %1$s.

I also took the opportunity to fix some capitalization issues.

Three questions -

  1. is app_name the place to put the name so it works with the parameter?
  2. do we have the ability to use a long name GeckoView Preview and a short name GV Preview?
  3. in the browser_menu_powered_by string the copy is all caps - and I either need to find a way to indicate that the parameter s/b all caps but would rather this be done for the whole string as a function of a style sheet not as a content and would like to use sentence case for the string in the xml file: Powered by GeckoView Preview

Please advise.

@mheubusch mheubusch added this to the Sprint 3-2 (Milestone 3) milestone Mar 26, 2019

@boek

This comment has been minimized.

Copy link
Member

boek commented Mar 26, 2019

Hey @mheubusch, sounds good. I will wrap this up tomorrow.

To answer your questions:

  1. app_name is probably what we will use 99% of the time
  2. If we have app_name and short_app_name we can inject that on a string by string basis
  3. We can capitalize it in the UI, and keep the capitalization normal in strings.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.