Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Crash on deleting bookmarks folder #16096

Closed
s-ankur opened this issue Oct 21, 2020 · 3 comments
Closed

[Bug] Crash on deleting bookmarks folder #16096

s-ankur opened this issue Oct 21, 2020 · 3 comments
Labels
b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, .. eng:ready Ready for engineering Feature:Bookmarks wontfix

Comments

@s-ankur
Copy link
Contributor

s-ankur commented Oct 21, 2020

Steps to reproduce

I was deleting a bookmarks folder while not signed in to synce

670e6271-4517-4703-9cca-fb9cfe07baf3
java.lang.NullPointerException
 * Sentry: https://sentry.prod.mozaws.net/operations/fenix/?query=055f8e7b94124a0890cbd93954f69cc6
 * Socorro: https://crash-stats.mozilla.org/report/index/bp-4029d057-af99-47e1-931d-94b710201021
----
java.lang.NullPointerException
	at org.mozilla.fenix.library.bookmarks.BookmarkFragment.refreshBookmarks(BookmarkFragment.kt:8)
	at org.mozilla.fenix.library.bookmarks.BookmarkFragment$refreshBookmarks$1.invokeSuspend(Unknown Source:11)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:3)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:15)
	at android.os.Handler.handleCallback(Handler.java:873)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:193)
	at android.app.ActivityThread.main(ActivityThread.java:6718)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

Actual behavior

Device information

  • Android device: Asus Zenfone
  • Fenix version: Nightly

┆Issue is synchronized with this Jira Task

@s-ankur s-ankur added the 🐞 bug Crashes, Something isn't working, .. label Oct 21, 2020
@s-ankur s-ankur changed the title [Bug] [Bug] Crash on deleting bookmarks folder Oct 21, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 21, 2020
@ekager ekager added b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info Feature:Bookmarks eng:ready Ready for engineering and removed needs:triage Issue needs triage labels Oct 21, 2020
@ekager ekager added this to Needs triage in Android: Stability Meta via automation Oct 21, 2020
@stale
Copy link

stale bot commented Apr 20, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 20, 2021
@stale stale bot closed this as completed Apr 27, 2021
@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Jun 2, 2021

I reproduced this crash on 90.0.0-beta1 while deleting bookmarks folders as well:
Steps:

  • I was signed in to sync.
  1. Have some bookmark folders, with bookmarks inside.
  2. Delete one folder after another, not letting the snackbar disappear in between (not sure if related though).
  3. Immediately after deleting the last folder, I entered in Edit mode for one of the bookmarks in the list.

device: Pixel 2 emulator, x86, Android 9

412139c4-735f-41ab-99ee-e7717c584356
java.lang.NullPointerException


java.lang.NullPointerException at org.mozilla.fenix.library.bookmarks.BookmarkFragment.refreshBookmarks(BookmarkFragment.kt:8) at org.mozilla.fenix.library.bookmarks.BookmarkFragment$refreshBookmarks$1.invokeSuspend(Unknown Source:11) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:3) at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:15) at android.os.Handler.handleCallback(Handler.java:873) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:193) at android.app.ActivityThread.main(ActivityThread.java:6669) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

@sv-ohorvath sv-ohorvath reopened this Jun 2, 2021
@stale stale bot removed the wontfix label Jun 2, 2021
@stale
Copy link

stale bot commented Nov 29, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 29, 2021
@stale stale bot closed this as completed Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, .. eng:ready Ready for engineering Feature:Bookmarks wontfix
Projects
No open projects
Android: Stability Meta
  
Needs triage
Development

No branches or pull requests

3 participants