Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Twitter asks to turn on notifications when already enabled #16411

Closed
jonalmeida opened this issue Nov 6, 2020 · 4 comments
Closed

[Bug] Twitter asks to turn on notifications when already enabled #16411

jonalmeida opened this issue Nov 6, 2020 · 4 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Push WebPush or Marketing push related features. needs:triage Issue needs triage

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Nov 6, 2020

Steps to reproduce

  1. Log into Twitter.
  2. Go to Settings > Push notifications.
  3. Toggle the switch on.
  4. Observe the Fenix site permissions prompt that asks for permission.
  5. Click 'Always'.
  6. Toggle the switch off then on again.
  7. Observe the page.

Expected behaviour

  • At 7, we should either see the twitter notification settings because the site permissions already allow twitter.com OR we are prompted again to allow site permissions.

Actual behavior

  • At 7, Twitter says to enable notifications from browser settings but we are never prompted for it.

Device information

  • Android device: Android 11, Pixel 4
  • Fenix version: Nightly, 201105 17:04 (Build #2015773899)

┆Issue is synchronized with this Jira Task

@jonalmeida jonalmeida added 🐞 bug Crashes, Something isn't working, .. Feature:Push WebPush or Marketing push related features. labels Nov 6, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 6, 2020
@Amejia481 Amejia481 self-assigned this Nov 6, 2020
@Amejia481 Amejia481 added this to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Nov 12, 2020
@Amejia481
Copy link
Contributor

The issue is address on mozilla-mobile/android-components#8944 and It will be fixed when Fenix update to the new ac version.

@Amejia481 Amejia481 moved this from 🏃‍♀️ In Progress to ⏳ Review/QA in A-C: Android Components Sprint Planning Nov 12, 2020
@Amejia481 Amejia481 added the eng:qa:needed QA Needed label Nov 17, 2020
@Amejia481
Copy link
Contributor

QA team could you please help us to verify if this is still reproducible in nightly ?

@jonalmeida
Copy link
Contributor Author

I just tested this out and it works for me now. :)

@ebalazs-sv
Copy link

Verified as fixed on the latest Nightly 201118 05:01 (Build #2015776297) GV 85 from 11/18 with Pixel 2 (Android 9).
I will close this issue and remove the qa:needed label.

A-C: Android Components Sprint Planning automation moved this from ⏳ Review/QA to 🏁 Done Nov 18, 2020
A-C: WebNotification & WebPush automation moved this from In progress to Done Nov 18, 2020
@ebalazs-sv ebalazs-sv added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Push WebPush or Marketing push related features. needs:triage Issue needs triage
Projects
No open projects
Development

No branches or pull requests

3 participants